Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: HA branch (HDFS-1623)
    • Fix Version/s: HA branch (HDFS-1623)
    • Component/s: datanode, ha
    • Labels:
      None

      Description

      For expediency in HDFS-1971 we've commented out the refreshNameNodes function temporarily on branch. Need to fix that code to handle refresh with HA.

      1. hdfs-2612.txt
        23 kB
        Todd Lipcon
      2. hdfs-2612.txt
        24 kB
        Todd Lipcon

        Activity

        Hide
        tlipcon Todd Lipcon added a comment -

        Attached patch applies on top of HDFS-1971. I broke out BlockPoolManager to a new file so I could easily add true unit tests against mocks. I ran all of the tests that call refreshNameNodes or call MiniDFSCluster.addNameNode, and they passed.

        I elected not to support changing the set of NNs within a namespace - you can only add or remove namespaces. Converting a namespace from non-HA to HA will require a restart. But I think that's fine for a first implementation, and we can always add that feature later if need be.

        Show
        tlipcon Todd Lipcon added a comment - Attached patch applies on top of HDFS-1971 . I broke out BlockPoolManager to a new file so I could easily add true unit tests against mocks. I ran all of the tests that call refreshNameNodes or call MiniDFSCluster.addNameNode, and they passed. I elected not to support changing the set of NNs within a namespace - you can only add or remove namespaces. Converting a namespace from non-HA to HA will require a restart. But I think that's fine for a first implementation, and we can always add that feature later if need be.
        Hide
        tlipcon Todd Lipcon added a comment -

        Fix whitespace and update onto tip of branch

        Show
        tlipcon Todd Lipcon added a comment - Fix whitespace and update onto tip of branch
        Hide
        eli Eli Collins added a comment -

        +1 lgtm

        Show
        eli Eli Collins added a comment - +1 lgtm
        Hide
        tlipcon Todd Lipcon added a comment -

        Committed to branch, thanks for the review.

        Show
        tlipcon Todd Lipcon added a comment - Committed to branch, thanks for the review.

          People

          • Assignee:
            tlipcon Todd Lipcon
            Reporter:
            tlipcon Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development