Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2609

DataNode.getDNRegistrationByMachineName can probably be removed or simplified

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Later
    • Affects Version/s: 0.23.0
    • Fix Version/s: None
    • Component/s: datanode
    • Labels:
      None

      Description

      I noticed this while working on HDFS-1971: The getDNRegistrationByMachineName iterates over block pools to return a given block pool's registration object based on its machineName field. But, the machine name for every BPOfferService is identical - they're always constructed by just calling DataNode.getName. All of the call sites for this function are from tests, as well. So, maybe it's not necessary, or at least it might be able to be simplified or moved to a test method.

        Issue Links

          Activity

          Hide
          Eli Collins added a comment -

          I'm fixing this in HDFS-3171

          Show
          Eli Collins added a comment - I'm fixing this in HDFS-3171
          Hide
          Todd Lipcon added a comment -

          Re-resolving with "Later" instead of "Fixed" since it's not fixed yet.

          Show
          Todd Lipcon added a comment - Re-resolving with "Later" instead of "Fixed" since it's not fixed yet.

            People

            • Assignee:
              Eli Collins
              Reporter:
              Todd Lipcon
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development