[HDFS-2609] DataNode.getDNRegistrationByMachineName can probably be removed or simplified

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Later
• Affects Version/s: 0.23.0
• Component/s: datanode
• Assignee: Eli Collins
• Reporter: Todd Lipcon
• Created: 30/Nov/11 06:55
• Updated: 22/Jun/12 05:02
• Resolved: 31/Mar/12 22:48

Description

I noticed this while working on HDFS-1971: The getDNRegistrationByMachineName iterates over block pools to return a given block pool's registration object based on its machineName field. But, the machine name for every BPOfferService is identical - they're always constructed by just calling DataNode.getName. All of the call sites for this function are from tests, as well. So, maybe it's not necessary, or at least it might be able to be simplified or moved to a test method.

Issue Links

• relates to: HDFS-3171 The DatanodeID "name" field is overloaded