Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2572

Unnecessary double-check in DN#getHostName

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.24.0
    • Fix Version/s: 2.1.0-beta
    • Component/s: datanode
    • Labels:
      None

      Description

      We do a double config.get unnecessarily inside DN#getHostName(...). Can be removed by this patch.

      1. HDFS-2572.patch
        0.9 kB
        Harsh J
      2. HDFS-2572.patch
        1.0 kB
        Harsh J

        Activity

        Hide
        Suresh Srinivas added a comment -

        I merged this change to 2.1.0-beta (though the merge resulted in no code change).

        Show
        Suresh Srinivas added a comment - I merged this change to 2.1.0-beta (though the merge resulted in no code change).
        Hide
        Suresh Srinivas added a comment -

        This code is only in trunk, updating the fix version accordingly.

        Show
        Suresh Srinivas added a comment - This code is only in trunk, updating the fix version accordingly.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #983 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/983/)
        HDFS-2572. Moved to trunk section from 0.23.1

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241746
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #983 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/983/ ) HDFS-2572 . Moved to trunk section from 0.23.1 acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241746 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #185 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/185/)
        HDFS-2572. Removed since it's only committed to trunk, not 0.23.0.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241747
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #185 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/185/ ) HDFS-2572 . Removed since it's only committed to trunk, not 0.23.0. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241747 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #163 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/163/)
        HDFS-2572. Removed since it's only committed to trunk, not 0.23.0.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241747
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #163 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/163/ ) HDFS-2572 . Removed since it's only committed to trunk, not 0.23.0. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241747 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #950 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/950/)
        HDFS-2572. Moved to trunk section from 0.23.1

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241746
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #950 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/950/ ) HDFS-2572 . Moved to trunk section from 0.23.1 acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241746 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Commit #522 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/522/)
        HDFS-2572. Removed since it's only committed to trunk, not 0.23.0.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241747
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #522 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/522/ ) HDFS-2572 . Removed since it's only committed to trunk, not 0.23.0. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241747 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1701 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1701/)
        HDFS-2572. Moved to trunk section from 0.23.1

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241746
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1701 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1701/ ) HDFS-2572 . Moved to trunk section from 0.23.1 acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241746 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Commit #507 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/507/)
        HDFS-2572. Removed since it's only committed to trunk, not 0.23.0.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241747
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #507 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/507/ ) HDFS-2572 . Removed since it's only committed to trunk, not 0.23.0. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241747 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1765 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1765/)
        HDFS-2572. Moved to trunk section from 0.23.1

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241746
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1765 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1765/ ) HDFS-2572 . Moved to trunk section from 0.23.1 acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241746 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-0.23-Commit #518 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/518/)
        HDFS-2572. Removed since it's only committed to trunk, not 0.23.0.

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241747
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #518 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/518/ ) HDFS-2572 . Removed since it's only committed to trunk, not 0.23.0. acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241747 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1690 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1690/)
        HDFS-2572. Moved to trunk section from 0.23.1

        acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241746
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1690 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1690/ ) HDFS-2572 . Moved to trunk section from 0.23.1 acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1241746 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        Eli Collins added a comment -

        Good candidate for merging to branch 23.

        Show
        Eli Collins added a comment - Good candidate for merging to branch 23.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #870 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/870/)
        HDFS-2572. Remove Unnecessary double-check in DN#getHostName (harsh)

        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1204177
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #870 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/870/ ) HDFS-2572 . Remove Unnecessary double-check in DN#getHostName (harsh) harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1204177 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #904 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/904/)
        HDFS-2572. Remove Unnecessary double-check in DN#getHostName (harsh)

        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1204177
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #904 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/904/ ) HDFS-2572 . Remove Unnecessary double-check in DN#getHostName (harsh) harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1204177 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12504429/HDFS-2572.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hdfs.TestDfsOverAvroRpc

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1590//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1590//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12504429/HDFS-2572.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.TestDfsOverAvroRpc +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1590//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1590//console This message is automatically generated.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1318 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1318/)
        HDFS-2572. Remove Unnecessary double-check in DN#getHostName (harsh)

        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1204177
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1318 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1318/ ) HDFS-2572 . Remove Unnecessary double-check in DN#getHostName (harsh) harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1204177 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        Hide
        Harsh J added a comment -

        Failing test is unrelated btw:

        java.lang.Exception: test timed out after 20000 milliseconds
        	at java.io.FileInputStream.readBytes(Native Method)
        	at java.io.FileInputStream.read(FileInputStream.java:220)
        	at sun.security.provider.SeedGenerator$URLSeedGenerator.getSeedBytes(SeedGenerator.java:493)
        	at sun.security.provider.SeedGenerator.generateSeed(SeedGenerator.java:117)
        	at sun.security.provider.SecureRandom.engineGenerateSeed(SecureRandom.java:114)
        	at sun.security.provider.SecureRandom.engineNextBytes(SecureRandom.java:171)
        	at java.security.SecureRandom.nextBytes(SecureRandom.java:433)
        	at java.security.SecureRandom.next(SecureRandom.java:455)
        	at java.util.Random.nextInt(Random.java:257)
        	at org.apache.hadoop.hdfs.server.namenode.NNStorage.newBlockPoolID(NNStorage.java:990)
        	at org.apache.hadoop.hdfs.server.namenode.NNStorage.format(NNStorage.java:537)
        	at org.apache.hadoop.hdfs.server.namenode.FSImage.format(FSImage.java:136)
        	at org.apache.hadoop.hdfs.server.namenode.NameNode.format(NameNode.java:607)
        	at org.apache.hadoop.hdfs.server.namenode.NameNode.format(NameNode.java:149)
        	at org.apache.hadoop.hdfs.DFSTestUtil.formatNameNode(DFSTestUtil.java:113)
        	at org.apache.hadoop.hdfs.MiniDFSCluster.createNameNode(MiniDFSCluster.java:630)
        	at org.apache.hadoop.hdfs.MiniDFSCluster.initMiniDFSCluster(MiniDFSCluster.java:545)
        	at org.apache.hadoop.hdfs.MiniDFSCluster.<init>(MiniDFSCluster.java:261)
        	at org.apache.hadoop.hdfs.MiniDFSCluster.<init>(MiniDFSCluster.java:85)
        	at org.apache.hadoop.hdfs.MiniDFSCluster$Builder.build(MiniDFSCluster.java:247)
        	at org.apache.hadoop.hdfs.TestLocalDFS.testWorkingDirectory(TestLocalDFS.java:66)
        	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        	at java.lang.reflect.Method.invoke(Method.java:597)
        	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
        	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
        	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
        	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
        	at org.junit.internal.runners.statements.FailOnTimeout$1.run(FailOnTimeout.java:28)
        

        Seems like the machine ran out of entropy, and timed out.

        Show
        Harsh J added a comment - Failing test is unrelated btw: java.lang.Exception: test timed out after 20000 milliseconds at java.io.FileInputStream.readBytes(Native Method) at java.io.FileInputStream.read(FileInputStream.java:220) at sun.security.provider.SeedGenerator$URLSeedGenerator.getSeedBytes(SeedGenerator.java:493) at sun.security.provider.SeedGenerator.generateSeed(SeedGenerator.java:117) at sun.security.provider.SecureRandom.engineGenerateSeed(SecureRandom.java:114) at sun.security.provider.SecureRandom.engineNextBytes(SecureRandom.java:171) at java.security.SecureRandom.nextBytes(SecureRandom.java:433) at java.security.SecureRandom.next(SecureRandom.java:455) at java.util.Random.nextInt(Random.java:257) at org.apache.hadoop.hdfs.server.namenode.NNStorage.newBlockPoolID(NNStorage.java:990) at org.apache.hadoop.hdfs.server.namenode.NNStorage.format(NNStorage.java:537) at org.apache.hadoop.hdfs.server.namenode.FSImage.format(FSImage.java:136) at org.apache.hadoop.hdfs.server.namenode.NameNode.format(NameNode.java:607) at org.apache.hadoop.hdfs.server.namenode.NameNode.format(NameNode.java:149) at org.apache.hadoop.hdfs.DFSTestUtil.formatNameNode(DFSTestUtil.java:113) at org.apache.hadoop.hdfs.MiniDFSCluster.createNameNode(MiniDFSCluster.java:630) at org.apache.hadoop.hdfs.MiniDFSCluster.initMiniDFSCluster(MiniDFSCluster.java:545) at org.apache.hadoop.hdfs.MiniDFSCluster.<init>(MiniDFSCluster.java:261) at org.apache.hadoop.hdfs.MiniDFSCluster.<init>(MiniDFSCluster.java:85) at org.apache.hadoop.hdfs.MiniDFSCluster$Builder.build(MiniDFSCluster.java:247) at org.apache.hadoop.hdfs.TestLocalDFS.testWorkingDirectory(TestLocalDFS.java:66) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) at org.junit.internal.runners.statements.FailOnTimeout$1.run(FailOnTimeout.java:28) Seems like the machine ran out of entropy, and timed out.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1294 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1294/)
        HDFS-2572. Remove Unnecessary double-check in DN#getHostName (harsh)

        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1204177
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1294 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1294/ ) HDFS-2572 . Remove Unnecessary double-check in DN#getHostName (harsh) harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1204177 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1368 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1368/)
        HDFS-2572. Remove Unnecessary double-check in DN#getHostName (harsh)

        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1204177
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1368 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1368/ ) HDFS-2572 . Remove Unnecessary double-check in DN#getHostName (harsh) harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1204177 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        Hide
        Harsh J added a comment -

        Nit fixed. Committing to trunk.

        Show
        Harsh J added a comment - Nit fixed. Committing to trunk.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12504422/HDFS-2572.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hdfs.TestDfsOverAvroRpc
        org.apache.hadoop.hdfs.TestLocalDFS

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1589//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1589//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12504422/HDFS-2572.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.TestDfsOverAvroRpc org.apache.hadoop.hdfs.TestLocalDFS +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1589//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1589//console This message is automatically generated.
        Hide
        Eli Collins added a comment -

        +1

        nit: you can put the assignment and declaration on the same line (String name = config.get(...))

        Show
        Eli Collins added a comment - +1 nit: you can put the assignment and declaration on the same line (String name = config.get(...))

          People

          • Assignee:
            Harsh J
            Reporter:
            Harsh J
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development