[HDFS-2495] Increase granularity of write operations in ReplicationMonitor thus reducing contention for write lock

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.23.0
• Fix Version/s: 2.0.0-alpha, 0.23.7
• Component/s: namenode
• Target Version/s: 0.23.3
• Hadoop Flags: Reviewed
• Assignee: Tomasz Nykiel
• Reporter: Tomasz Nykiel
• Created: 24/Oct/11 10:00
• Updated: 28/Sep/15 20:58
• Resolved: 08/Nov/11 00:17

Description

For processing blocks in ReplicationMonitor (BlockManager.computeReplicationWork), we first obtain a list of blocks to be replicated by calling chooseUnderReplicatedBlocks, and then for each block which was found, we call computeReplicationWorkForBlock. The latter processes a block in three stages, acquiring the writelock twice per call:

1. obtaining block related info (livenodes, srcnode, etc.) under lock
2. choosing target for replication
3. scheduling replication (under lock)

We would like to change this behaviour and decrease contention for the write lock, by batching blocks and executing 1,2,3, for sets of blocks, rather than for each one separately. This would decrease the number of writeLock to 2, from 2*numberofblocks.

Also, the info level logging can be pushed outside the writelock.