Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-2352

improve TestOfflineEditsViewer to accomodate comment in editsStored.xml, for Apache license header

    XMLWordPrintableJSON

Details

    • Test
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • 0.23.0
    • None
    • test
    • None

    Description

      In HDFS-2344, we had to remove the license header comment from hadoop-hdfs-project/hadoop-hdfs/src/test/resources/editsStored.xml in order to accomodate a binary file-equal-to-expected-results test in TestOfflineEditsViewer#testStored().

      It would be a better solution to modify #filesEqual() to test the XML object equality, ignoring comments, rather than a simple-minded binary file equality.

      Attachments

        Activity

          People

            Unassigned Unassigned
            mattf Matthew Foley
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated: