Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-2313

Rat excludes has a typo for excluding editsStored files

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In hadoop-hdfs-project/hadoop-hdfs/pom.xml, this:

      <exclude>src/test/resources/editStored*</exclude>
      

      Should be:

      <exclude>src/test/resources/editsStored*</exclude>
      
      1. hdfs-2313.0.patch
        0.7 kB
        Aaron T. Myers

        Activity

        Hide
        atm Aaron T. Myers added a comment -

        Patch which addresses the issue.

        Show
        atm Aaron T. Myers added a comment - Patch which addresses the issue.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12493088/hdfs-2313.0.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:

        org.apache.hadoop.hdfs.server.namenode.TestBackupNode
        org.apache.hadoop.hdfs.TestDfsOverAvroRpc
        org.apache.hadoop.hdfs.server.blockmanagement.TestHost2NodesMap
        org.apache.hadoop.hdfs.server.datanode.TestReplicasMap

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1199//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1199//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1199//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12493088/hdfs-2313.0.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.server.namenode.TestBackupNode org.apache.hadoop.hdfs.TestDfsOverAvroRpc org.apache.hadoop.hdfs.server.blockmanagement.TestHost2NodesMap org.apache.hadoop.hdfs.server.datanode.TestReplicasMap +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1199//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1199//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1199//console This message is automatically generated.
        Hide
        tomwhite Tom White added a comment -

        +1

        Show
        tomwhite Tom White added a comment - +1
        Hide
        umamaheswararao Uma Maheswara Rao G added a comment -

        +1

        when i test with out this also i observed there is no increase. But i have seen some of the hudson builds incresed the count.let me digg into my local setup once cleanly.

        By the above hudson results, we can be confident that there is no increases in comments.

        Thanks a lot for the patch!

        Show
        umamaheswararao Uma Maheswara Rao G added a comment - +1 when i test with out this also i observed there is no increase. But i have seen some of the hudson builds incresed the count.let me digg into my local setup once cleanly. By the above hudson results, we can be confident that there is no increases in comments. Thanks a lot for the patch!
        Hide
        atm Aaron T. Myers added a comment -

        Thanks a lot for the review, Tom. I've just committed this.

        Show
        atm Aaron T. Myers added a comment - Thanks a lot for the review, Tom. I've just committed this.
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #911 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/911/)
        HDFS-2313. Rat excludes has a typo for excluding editsStored files. (atm)

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1165477
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #911 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/911/ ) HDFS-2313 . Rat excludes has a typo for excluding editsStored files. (atm) atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1165477 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #845 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/845/)
        HDFS-2313. Rat excludes has a typo for excluding editsStored files. (atm)

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1165477
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #845 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/845/ ) HDFS-2313 . Rat excludes has a typo for excluding editsStored files. (atm) atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1165477 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #785 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/785/)
        HDFS-2313. Rat excludes has a typo for excluding editsStored files. (atm)

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1165477
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #785 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/785/ ) HDFS-2313 . Rat excludes has a typo for excluding editsStored files. (atm) atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1165477 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #808 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/808/)
        HDFS-2313. Rat excludes has a typo for excluding editsStored files. (atm)

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1165477
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #808 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/808/ ) HDFS-2313 . Rat excludes has a typo for excluding editsStored files. (atm) atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1165477 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml

          People

          • Assignee:
            atm Aaron T. Myers
            Reporter:
            atm Aaron T. Myers
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development