Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2287

TestParallelRead has a small off-by-one bug

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.22.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Noticed this bug when I was running TestParallelRead - a simple off-by-one error in some internal bounds checking.

      1. hdfs-2287-v-0.22.patch
        1 kB
        Konstantin Shvachko
      2. hdfs-2287.txt
        1 kB
        Todd Lipcon

        Issue Links

          Activity

          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12491577/hdfs-2287.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:

          org.apache.hadoop.hdfs.TestDfsOverAvroRpc
          org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
          org.apache.hadoop.hdfs.server.blockmanagement.TestHost2NodesMap

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1158//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1158//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1158//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12491577/hdfs-2287.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.TestDfsOverAvroRpc org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer org.apache.hadoop.hdfs.server.blockmanagement.TestHost2NodesMap +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1158//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1158//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1158//console This message is automatically generated.
          Hide
          Eli Collins added a comment -

          +1 lgtm

          Show
          Eli Collins added a comment - +1 lgtm
          Hide
          Todd Lipcon added a comment -

          Committed to trunk only. We can backport to earlier branches if we ever see this fail.

          Show
          Todd Lipcon added a comment - Committed to trunk only. We can backport to earlier branches if we ever see this fail.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #796 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/796/)
          HDFS-2287. TestParallelRead has a small off-by-one bug. Contributed by Todd Lipcon.

          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1162005
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestParallelRead.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #796 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/796/ ) HDFS-2287 . TestParallelRead has a small off-by-one bug. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1162005 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestParallelRead.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #873 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/873/)
          HDFS-2287. TestParallelRead has a small off-by-one bug. Contributed by Todd Lipcon.

          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1162005
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestParallelRead.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #873 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/873/ ) HDFS-2287 . TestParallelRead has a small off-by-one bug. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1162005 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestParallelRead.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #806 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/806/)
          HDFS-2287. TestParallelRead has a small off-by-one bug. Contributed by Todd Lipcon.

          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1162005
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestParallelRead.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #806 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/806/ ) HDFS-2287 . TestParallelRead has a small off-by-one bug. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1162005 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestParallelRead.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #771 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/771/)
          HDFS-2287. TestParallelRead has a small off-by-one bug. Contributed by Todd Lipcon.

          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1162005
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestParallelRead.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #771 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/771/ ) HDFS-2287 . TestParallelRead has a small off-by-one bug. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1162005 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestParallelRead.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #794 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/794/)
          HDFS-2287. TestParallelRead has a small off-by-one bug. Contributed by Todd Lipcon.

          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1162005
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestParallelRead.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #794 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/794/ ) HDFS-2287 . TestParallelRead has a small off-by-one bug. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1162005 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestParallelRead.java
          Hide
          Konstantin Shvachko added a comment -

          Todd, you fixed the first assert in read(), but missed the second one in pRead().

          Show
          Konstantin Shvachko added a comment - Todd, you fixed the first assert in read() , but missed the second one in pRead() .
          Hide
          Todd Lipcon added a comment -

          doh! my bad....

          Show
          Todd Lipcon added a comment - doh! my bad....
          Hide
          Konstantin Shvachko added a comment -

          Second assert need to be fixed.

          Show
          Konstantin Shvachko added a comment - Second assert need to be fixed.
          Hide
          Konstantin Shvachko added a comment -

          Committed to 0.22 and updated the second assert for trunk.

          Show
          Konstantin Shvachko added a comment - Committed to 0.22 and updated the second assert for trunk.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #1336 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1336/)
          HDFS-2287. Fix second assert.

          shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1207710
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestParallelRead.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1336 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1336/ ) HDFS-2287 . Fix second assert. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1207710 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestParallelRead.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #1411 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1411/)
          HDFS-2287. Fix second assert.

          shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1207710
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestParallelRead.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1411 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1411/ ) HDFS-2287 . Fix second assert. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1207710 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestParallelRead.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #1360 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1360/)
          HDFS-2287. Fix second assert.

          shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1207710
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestParallelRead.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1360 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1360/ ) HDFS-2287 . Fix second assert. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1207710 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestParallelRead.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-22-branch #115 (See https://builds.apache.org/job/Hadoop-Hdfs-22-branch/115/)
          HDFS-2287. TestParallelRead has a small off-by-one bug. Contributed by Todd Lipcon.

          shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1207711
          Files :

          • /hadoop/common/branches/branch-0.22/hdfs/CHANGES.txt
          • /hadoop/common/branches/branch-0.22/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/TestParallelRead.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-22-branch #115 (See https://builds.apache.org/job/Hadoop-Hdfs-22-branch/115/ ) HDFS-2287 . TestParallelRead has a small off-by-one bug. Contributed by Todd Lipcon. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1207711 Files : /hadoop/common/branches/branch-0.22/hdfs/CHANGES.txt /hadoop/common/branches/branch-0.22/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/TestParallelRead.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #879 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/879/)
          HDFS-2287. Fix second assert.

          shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1207710
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestParallelRead.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #879 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/879/ ) HDFS-2287 . Fix second assert. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1207710 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestParallelRead.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #912 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/912/)
          HDFS-2287. Fix second assert.

          shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1207710
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestParallelRead.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #912 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/912/ ) HDFS-2287 . Fix second assert. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1207710 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestParallelRead.java

            People

            • Assignee:
              Todd Lipcon
              Reporter:
              Todd Lipcon
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development