Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. HDFS-2199.1.patch
      20 kB
      Uma Maheswara Rao G
    2. HDFS-2199.patch
      22 kB
      Uma Maheswara Rao G

      Activity

      Transition Time In Source Status Execution Times Last Executer Last Execution Date
      Patch Available Patch Available Open Open
      2d 23h 35m 1 Uma Maheswara Rao G 01/Aug/11 13:19
      Open Open Patch Available Patch Available
      3d 4h 27m 2 Uma Maheswara Rao G 01/Aug/11 13:19
      Patch Available Patch Available Resolved Resolved
      1h 40m 1 Tsz Wo Nicholas Sze 01/Aug/11 14:59
      Resolved Resolved Closed Closed
      105d 10h 53m 1 Arun C Murthy 15/Nov/11 00:53
      Arun C Murthy made changes -
      Status Resolved [ 5 ] Closed [ 6 ]
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Hdfs-trunk-Commit #812 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/812/)
      HDFS-2199. Move blockTokenSecretManager from FSNamesystem to BlockManager. Contributed by Uma Maheswara Rao G

      szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1152776
      Files :

      • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
      • /hadoop/common/trunk/hdfs/CHANGES.txt
      • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestBlockTokenWithDFS.java
      • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
      • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java
      • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
      Show
      Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #812 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/812/ ) HDFS-2199 . Move blockTokenSecretManager from FSNamesystem to BlockManager. Contributed by Uma Maheswara Rao G szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1152776 Files : /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/trunk/hdfs/CHANGES.txt /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestBlockTokenWithDFS.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Hdfs-trunk #738 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/738/)
      HDFS-2199. Move blockTokenSecretManager from FSNamesystem to BlockManager. Contributed by Uma Maheswara Rao G

      szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1152776
      Files :

      • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
      • /hadoop/common/trunk/hdfs/CHANGES.txt
      • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestBlockTokenWithDFS.java
      • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
      • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java
      • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
      Show
      Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #738 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/738/ ) HDFS-2199 . Move blockTokenSecretManager from FSNamesystem to BlockManager. Contributed by Uma Maheswara Rao G szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1152776 Files : /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/trunk/hdfs/CHANGES.txt /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestBlockTokenWithDFS.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
      Tsz Wo Nicholas Sze made changes -
      Status Patch Available [ 10002 ] Resolved [ 5 ]
      Hadoop Flags [Reviewed]
      Fix Version/s 0.23.0 [ 12315571 ]
      Resolution Fixed [ 1 ]
      Hide
      Tsz Wo Nicholas Sze added a comment -

      +1 patch looks good

      I have committed this. Thanks, Uma!

      Show
      Tsz Wo Nicholas Sze added a comment - +1 patch looks good I have committed this. Thanks, Uma!
      Hide
      Uma Maheswara Rao G added a comment -

      Thanks Nicholas for taking a look.

      Patch updated for the trunk!

      Test Patch Results:
      [exec] +1 overall.
      [exec]
      [exec] +1 @author. The patch does not contain any @author tags.
      [exec]
      [exec] +1 tests included. The patch appears to include 3 new or modified tests.
      [exec]
      [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
      [exec]
      [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
      [exec]
      [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
      [exec]
      [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
      [exec]
      [exec] +1 system test framework. The patch passed system test framework compile.
      [exec]

      When run tests, TestCorruptFilesJsp failed.But passing in eclipse. This is not relevant to this change.

      Show
      Uma Maheswara Rao G added a comment - Thanks Nicholas for taking a look. Patch updated for the trunk! Test Patch Results: [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system test framework. The patch passed system test framework compile. [exec] When run tests, TestCorruptFilesJsp failed.But passing in eclipse. This is not relevant to this change.
      Uma Maheswara Rao G made changes -
      Status Open [ 1 ] Patch Available [ 10002 ]
      Uma Maheswara Rao G made changes -
      Status Patch Available [ 10002 ] Open [ 1 ]
      Uma Maheswara Rao G made changes -
      Attachment HDFS-2199.1.patch [ 12488397 ]
      Hide
      Tsz Wo Nicholas Sze added a comment -

      The patch does not apply to trunk anymore. Could you update it? Otherwise, it looks good.

      Please also run "ant test" and "ant test-patch" manually.

      Show
      Tsz Wo Nicholas Sze added a comment - The patch does not apply to trunk anymore. Could you update it? Otherwise, it looks good. Please also run "ant test" and "ant test-patch" manually.
      Hide
      Uma Maheswara Rao G added a comment -

      [exec] +1 overall.
      [exec]
      [exec] +1 @author. The patch does not contain any @author tags.
      [exec]
      [exec] +1 tests included. The patch appears to include 3 new or modified tests.
      [exec]
      [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
      [exec]
      [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
      [exec]
      [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
      [exec]
      [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
      [exec]
      [exec] +1 system test framework. The patch passed system test framework compile.
      Local verification results!.

      Show
      Uma Maheswara Rao G added a comment - [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system test framework. The patch passed system test framework compile. Local verification results!.
      Uma Maheswara Rao G made changes -
      Status Open [ 1 ] Patch Available [ 10002 ]
      Hide
      Uma Maheswara Rao G added a comment -

      Updated patch for review!

      Show
      Uma Maheswara Rao G added a comment - Updated patch for review!
      Uma Maheswara Rao G made changes -
      Attachment HDFS-2199.patch [ 12488199 ]
      Uma Maheswara Rao G made changes -
      Assignee Uma Maheswara Rao G [ umamaheswararao ]
      Tsz Wo Nicholas Sze made changes -
      Field Original Value New Value
      Component/s name-node [ 12312926 ]
      Tsz Wo Nicholas Sze created issue -

        People

        • Assignee:
          Uma Maheswara Rao G
          Reporter:
          Tsz Wo Nicholas Sze
        • Votes:
          0 Vote for this issue
          Watchers:
          3 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development