Details

    • Type: Test Test
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.20.1, 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. HADOOP-7361-test.patch
      3 kB
      Uma Maheswara Rao G
    2. HADOOP-7361-test.patch
      6 kB
      Uma Maheswara Rao G
    3. HADOOP-7361-test.patch
      6 kB
      Uma Maheswara Rao G
    4. HADOOP-7361-test_v3.patch
      6 kB
      Matt Foley

      Issue Links

        Activity

        Hide
        Uma Maheswara Rao G added a comment -

        This is testcode for HADOOP-7361

        Show
        Uma Maheswara Rao G added a comment - This is testcode for HADOOP-7361
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12485438/HADOOP-7361-test.patch
        against trunk revision 1143147.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.hdfs.server.namenode.TestBackupNode
        org.apache.hadoop.hdfs.TestDFSShell
        org.apache.hadoop.hdfs.TestSeekBug

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/879//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/879//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/879//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12485438/HADOOP-7361-test.patch against trunk revision 1143147. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.server.namenode.TestBackupNode org.apache.hadoop.hdfs.TestDFSShell org.apache.hadoop.hdfs.TestSeekBug +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/879//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/879//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/879//console This message is automatically generated.
        Hide
        Uma Maheswara Rao G added a comment -

        TestDFSShell will pass after commiting the patch HADOOP-7361.
        remaining failures are not related to this patch.

        Show
        Uma Maheswara Rao G added a comment - TestDFSShell will pass after commiting the patch HADOOP-7361 . remaining failures are not related to this patch.
        Hide
        Daryn Sharp added a comment -

        These tests are probably better suited to TestHDFSCLI. Although I'm not fond of the custom framework and it's weak integration with junit, testing for a -1 return is a feeble check since it can occur for any number of reasons. The TestHDFSCLI tests will let you verify that the exception output is correct. Come to think of it, I'm surprised the commands aren't failing with exit 1... -1 is usually a usage error.

        Show
        Daryn Sharp added a comment - These tests are probably better suited to TestHDFSCLI . Although I'm not fond of the custom framework and it's weak integration with junit, testing for a -1 return is a feeble check since it can occur for any number of reasons. The TestHDFSCLI tests will let you verify that the exception output is correct. Come to think of it, I'm surprised the commands aren't failing with exit 1... -1 is usually a usage error.
        Hide
        Uma Maheswara Rao G added a comment -

        Hi Daryn,
        Thanks a lot for taking a look into the patch.
        Updated the patch. Added the tests in TestHDFSCLI.

        Show
        Uma Maheswara Rao G added a comment - Hi Daryn, Thanks a lot for taking a look into the patch. Updated the patch. Added the tests in TestHDFSCLI.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12485611/HADOOP-7361-test.patch
        against trunk revision 1143147.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 15 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.cli.TestHDFSCLI
        org.apache.hadoop.hdfs.TestDFSShell
        org.apache.hadoop.hdfs.TestHDFSTrash

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/894//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/894//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/894//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12485611/HADOOP-7361-test.patch against trunk revision 1143147. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 15 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.cli.TestHDFSCLI org.apache.hadoop.hdfs.TestDFSShell org.apache.hadoop.hdfs.TestHDFSTrash +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/894//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/894//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/894//console This message is automatically generated.
        Hide
        Daryn Sharp added a comment -

        Wonderful! Only nit to is to change the fail(...) to assertEquals(...). It's a bit annoying when a test fails and doesn't show what the unexpected value is, whereas assertEquals will show expected and actual.

        Show
        Daryn Sharp added a comment - Wonderful! Only nit to is to change the fail(...) to assertEquals(...) . It's a bit annoying when a test fails and doesn't show what the unexpected value is, whereas assertEquals will show expected and actual.
        Hide
        Uma Maheswara Rao G added a comment -

        Thanks Daryn!
        Addressed the nit and good point .

        Show
        Uma Maheswara Rao G added a comment - Thanks Daryn! Addressed the nit and good point .
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12485690/HADOOP-7361-test.patch
        against trunk revision 1144100.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 15 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.cli.TestHDFSCLI
        org.apache.hadoop.hdfs.server.namenode.TestStartup
        org.apache.hadoop.hdfs.TestDFSShell

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/898//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/898//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/898//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12485690/HADOOP-7361-test.patch against trunk revision 1144100. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 15 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.cli.TestHDFSCLI org.apache.hadoop.hdfs.server.namenode.TestStartup org.apache.hadoop.hdfs.TestDFSShell +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/898//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/898//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/898//console This message is automatically generated.
        Hide
        Daryn Sharp added a comment -

        +1 good job!

        Show
        Daryn Sharp added a comment - +1 good job!
        Hide
        Uma Maheswara Rao G added a comment -

        Thanks Daryn! for taking a look.

        Show
        Uma Maheswara Rao G added a comment - Thanks Daryn! for taking a look.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Let's resubmit this after HADOOP-7361 is integrated.

        Show
        Tsz Wo Nicholas Sze added a comment - Let's resubmit this after HADOOP-7361 is integrated.
        Hide
        Matt Foley added a comment -

        Nicholas, it's my understanding that having once run against uploaded file [12485690] (HADOOP-7361-test.patch of 08/Jul/11), Jenkins will not test the same file again even if "Patch Available" is bounced. So I'm uploading another copy of the same file, to trigger auto-test. I've named it "_v3" to clarify that it is the same file as the third one Uma uploaded.

        Uma, in future please change the name of a file when you update it, e.g. by adding "_v2" to it. Otherwise we can't tell if the new upload is a new file, or just another copy of the same file. Thanks.

        Show
        Matt Foley added a comment - Nicholas, it's my understanding that having once run against uploaded file [12485690] ( HADOOP-7361 -test.patch of 08/Jul/11), Jenkins will not test the same file again even if "Patch Available" is bounced. So I'm uploading another copy of the same file, to trigger auto-test. I've named it "_v3" to clarify that it is the same file as the third one Uma uploaded. Uma, in future please change the name of a file when you update it, e.g. by adding "_v2" to it. Otherwise we can't tell if the new upload is a new file, or just another copy of the same file. Thanks.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12486250/HADOOP-7361-test_v3.patch
        against trunk revision 1145834.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 15 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/913//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/913//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/913//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12486250/HADOOP-7361-test_v3.patch against trunk revision 1145834. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 15 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/913//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/913//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/913//console This message is automatically generated.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Matt, thanks for posting a new file.

        Show
        Tsz Wo Nicholas Sze added a comment - Matt, thanks for posting a new file.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have committed this. Thanks, Uma.

        Also thanks Daryn for reviewing it.

        Show
        Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Uma. Also thanks Daryn for reviewing it.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #784 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/784/)
        HDFS-2131. Add new tests for the -overwrite/-f option in put and copyFromLocal by HADOOP-7361. Contributed by Uma Maheswara Rao G

        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1145843
        Files :

        • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/cli/testHDFSConf.xml
        • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/TestDFSShell.java
        • /hadoop/common/trunk/hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #784 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/784/ ) HDFS-2131 . Add new tests for the -overwrite/-f option in put and copyFromLocal by HADOOP-7361 . Contributed by Uma Maheswara Rao G szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1145843 Files : /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/cli/testHDFSConf.xml /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/TestDFSShell.java /hadoop/common/trunk/hdfs/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #723 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/723/)
        HDFS-2131. Add new tests for the -overwrite/-f option in put and copyFromLocal by HADOOP-7361. Contributed by Uma Maheswara Rao G

        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1145843
        Files :

        • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/cli/testHDFSConf.xml
        • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/TestDFSShell.java
        • /hadoop/common/trunk/hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #723 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/723/ ) HDFS-2131 . Add new tests for the -overwrite/-f option in put and copyFromLocal by HADOOP-7361 . Contributed by Uma Maheswara Rao G szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1145843 Files : /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/cli/testHDFSConf.xml /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/TestDFSShell.java /hadoop/common/trunk/hdfs/CHANGES.txt
        Hide
        Todd Lipcon added a comment -

        This patch is now leaving around a directory "ForceTestDir" in the build tree. This should go inside the build dir.

        Show
        Todd Lipcon added a comment - This patch is now leaving around a directory "ForceTestDir" in the build tree. This should go inside the build dir.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Sorry Todd, filed HDFS-2154.

        Show
        Tsz Wo Nicholas Sze added a comment - Sorry Todd, filed HDFS-2154 .
        Hide
        Uma Maheswara Rao G added a comment -

        Sorry, Just now i have seen it.
        I was trying to update the patch...Looks Nicholas already updated it.

        Thanks a lot Nicholas. and Todd for noticing it.

        Show
        Uma Maheswara Rao G added a comment - Sorry, Just now i have seen it. I was trying to update the patch...Looks Nicholas already updated it. Thanks a lot Nicholas. and Todd for noticing it.

          People

          • Assignee:
            Uma Maheswara Rao G
            Reporter:
            Uma Maheswara Rao G
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development