Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2082

SecondaryNameNode web interface doesn't show the right info

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0, 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: None
    • Labels:
      None

      Description

      HADOOP-3741 introduced some useful info to the 2NN web UI. This broke when security was added.

      1. hdfs-2082.3.patch
        3 kB
        Aaron T. Myers
      2. hdfs-2082.2.patch
        3 kB
        Aaron T. Myers
      3. hdfs-2082.1.patch
        3 kB
        Aaron T. Myers
      4. hdfs-2082.0.patch
        0.8 kB
        Aaron T. Myers

        Activity

        Hide
        Aaron T. Myers added a comment -

        Patch which fixes the issue. I manually verified that the web UI again displays the correct information.

        Show
        Aaron T. Myers added a comment - Patch which fixes the issue. I manually verified that the web UI again displays the correct information.
        Hide
        Todd Lipcon added a comment -

        Seems reasonable. Would it be possible to add a simple test which just fetches the page and checks for some kind of simple string? See TestFairSchedulerSystem#checkServlet in MR for an example of the sort of simple test I mean.

        Show
        Todd Lipcon added a comment - Seems reasonable. Would it be possible to add a simple test which just fetches the page and checks for some kind of simple string? See TestFairSchedulerSystem#checkServlet in MR for an example of the sort of simple test I mean.
        Hide
        Aaron T. Myers added a comment -

        Updated patch which adds a test.

        Todd, would you like me to run TestDFSIO as well?

        Show
        Aaron T. Myers added a comment - Updated patch which adds a test. Todd, would you like me to run TestDFSIO as well?
        Hide
        Aaron T. Myers added a comment -

        Updated patch which shuts down the mini cluster upon finishing.

        Thanks very much for your thoughtful reviews, Todd.

        Show
        Aaron T. Myers added a comment - Updated patch which shuts down the mini cluster upon finishing. Thanks very much for your thoughtful reviews, Todd.
        Hide
        Aaron T. Myers added a comment -

        Updated patch which shuts down the 2NN upon completion of the test.

        Show
        Aaron T. Myers added a comment - Updated patch which shuts down the 2NN upon completion of the test.
        Hide
        Todd Lipcon added a comment -

        +1 pending Hudson results

        Show
        Todd Lipcon added a comment - +1 pending Hudson results
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12483007/hdfs-2082.0.patch
        against trunk revision 1136975.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/793//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/793//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/793//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12483007/hdfs-2082.0.patch against trunk revision 1136975. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/793//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/793//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/793//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12483014/hdfs-2082.3.patch
        against trunk revision 1136975.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:

        -1 contrib tests. The patch failed contrib unit tests.

        -1 system test framework. The patch failed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/795//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/795//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/795//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12483014/hdfs-2082.3.patch against trunk revision 1136975. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: -1 contrib tests. The patch failed contrib unit tests. -1 system test framework. The patch failed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/795//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/795//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/795//console This message is automatically generated.
        Hide
        Aaron T. Myers added a comment -

        Strange - the test-patch Hudson run failed with an error I've never seen before:

        [exec]     [junit] Running org.apache.hadoop.hdfs.TestLeaseRecovery2
        FATAL: Unable to delete script file /tmp/hudson6321136650233756293.sh
        hudson.util.IOException2: remote file operation failed: /tmp/hudson6321136650233756293.sh at hudson.remoting.Channel@6eee1e2:hadoop8
        

        Anyway, manually running ant test-core on my box with this patch resulted in no test failures.

        Show
        Aaron T. Myers added a comment - Strange - the test-patch Hudson run failed with an error I've never seen before: [exec] [junit] Running org.apache.hadoop.hdfs.TestLeaseRecovery2 FATAL: Unable to delete script file /tmp/hudson6321136650233756293.sh hudson.util.IOException2: remote file operation failed: /tmp/hudson6321136650233756293.sh at hudson.remoting.Channel@6eee1e2:hadoop8 Anyway, manually running ant test-core on my box with this patch resulted in no test failures.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12483014/hdfs-2082.3.patch
        against trunk revision 1137675.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.hdfs.TestSetTimes

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/801//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/801//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/801//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12483014/hdfs-2082.3.patch against trunk revision 1137675. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.TestSetTimes +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/801//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/801//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/801//console This message is automatically generated.
        Hide
        Aaron T. Myers added a comment -

        I'm pretty confident this test failure was spurious. The test just passed locally on my box.

        Curiously, I've never seen TestSetTimes fail though.

        Show
        Aaron T. Myers added a comment - I'm pretty confident this test failure was spurious. The test just passed locally on my box. Curiously, I've never seen TestSetTimes fail though.
        Hide
        Todd Lipcon added a comment -

        +1

        Show
        Todd Lipcon added a comment - +1
        Hide
        Aaron T. Myers added a comment -

        Thanks a lot, Todd. I've just committed this.

        Show
        Aaron T. Myers added a comment - Thanks a lot, Todd. I've just committed this.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #758 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/758/)
        HDFS-2082. SecondaryNameNode web interface doesn't show the right info. Contributed by Aaron T. Myers.

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1139397
        Files :

        • /hadoop/common/trunk/hdfs/CHANGES.txt
        • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
        • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestSecondaryWebUi.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #758 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/758/ ) HDFS-2082 . SecondaryNameNode web interface doesn't show the right info. Contributed by Aaron T. Myers. atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1139397 Files : /hadoop/common/trunk/hdfs/CHANGES.txt /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestSecondaryWebUi.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #707 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/707/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #707 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/707/ )

          People

          • Assignee:
            Aaron T. Myers
            Reporter:
            Aaron T. Myers
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development