Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2038

Update test to handle relative paths with globs

    Details

    • Type: Test Test
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 2.0.0-alpha
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This is providing the test updates for FsShell to retain relativity for paths with globs.

      1. HDFS-2038.patch
        94 kB
        Daryn Sharp
      2. HDFS-2038-2.patch
        394 kB
        Daryn Sharp
      3. disable-TestHDFSCLI.patch
        0.6 kB
        Tsz Wo Nicholas Sze
      4. hdfs-2038.patch.txt
        421 kB
        Kihwal Lee
      5. hdfs-2038.branch-0.23.2.supplemental.patch
        4 kB
        Kihwal Lee

        Issue Links

          Activity

          Hide
          Eli Collins added a comment -

          Andrew Wang fixed this in HDFS-2963.

          Show
          Eli Collins added a comment - Andrew Wang fixed this in HDFS-2963 .
          Hide
          Eli Collins added a comment -

          The following is still in the code, it can be removed now right?

            //TODO: The test is failing due to the change in HADOOP-7360.
            //      HDFS-2038 is going to fix it.  Disable the test for the moment.
          
          Show
          Eli Collins added a comment - The following is still in the code, it can be removed now right? //TODO: The test is failing due to the change in HADOOP-7360. // HDFS-2038 is going to fix it. Disable the test for the moment.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I have committed this to trunk, 0.23 and 0.23.2. Thanks, Kihwal and Daryn!

          Show
          Tsz Wo Nicholas Sze added a comment - I have committed this to trunk, 0.23 and 0.23.2. Thanks, Kihwal and Daryn!
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Hi Kihwal, you are right that it makes a difference if I run the test from the project root. It passes now. I have learned something from you. Thanks!

          Show
          Tsz Wo Nicholas Sze added a comment - Hi Kihwal, you are right that it makes a difference if I run the test from the project root. It passes now. I have learned something from you. Thanks!
          Hide
          Kihwal Lee added a comment -

          I even blew away .m2 and did everything fresh. It still passes.

          Are you building/running test from the root or under hadoop-hdfs project? If you are doing it under the project directory, the build might be picking up an old artifact, probably from old branch-0.23 builds.

          Show
          Kihwal Lee added a comment - I even blew away .m2 and did everything fresh. It still passes. Are you building/running test from the root or under hadoop-hdfs project? If you are doing it under the project directory, the build might be picking up an old artifact, probably from old branch-0.23 builds.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Daryn, we did you get if you run the test on 0.23.2?

          Show
          Tsz Wo Nicholas Sze added a comment - Daryn, we did you get if you run the test on 0.23.2?
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I just have cleaned and re-run the test, still got the same output.

          Show
          Tsz Wo Nicholas Sze added a comment - I just have cleaned and re-run the test, still got the same output.
          Hide
          Kihwal Lee added a comment -

          That's strange. It passes on the current 0.23.2 with the supplemental patch for me. I reran multiple times.

          As for the error messages, they are like that since the path validation is done on destination first. In this case the parent directory of the destination doesn't exist. I think the error message can be more descriptive. I will discuss with Daryn and let him file a Jira for the improvement.

          In any case, would you retry the patch?

          Show
          Kihwal Lee added a comment - That's strange. It passes on the current 0.23.2 with the supplemental patch for me. I reran multiple times. As for the error messages, they are like that since the path validation is done on destination first. In this case the parent directory of the destination doesn't exist. I think the error message can be more descriptive. I will discuss with Daryn and let him file a Jira for the improvement. In any case, would you retry the patch?
          Hide
          Daryn Sharp added a comment -

          Agreed that test 89 appears to expect the wrong output, but test 54 looks very odd. It doesn't look like it should fail at all, let alone with I/O error.

          Show
          Daryn Sharp added a comment - Agreed that test 89 appears to expect the wrong output, but test 54 looks very odd. It doesn't look like it should fail at all, let alone with I/O error.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          With hdfs-2038.branch-0.23.2.supplemental.patch, there are still two tests failed. However, it looks like that the actual outputs are correct and the expected outputs are incorrect, i.e. the tests are incorrect. See below. Trunk has a similar problem except that both the expected and actual outputs are incorrect. So that the tests passed.

          //0.23.2
          2012-03-08 11:10:24,774 INFO ...(156)) - -------------------------------------------
          2012-03-08 11:10:24,774 INFO ...(157)) -                     Test ID: [54]
          2012-03-08 11:10:24,775 INFO ...(158)) -            Test Description: [mv: file (absolute path) to file (relative path)]
          2012-03-08 11:10:24,775 INFO ...(159)) - 
          2012-03-08 11:10:24,775 INFO ...(163)) -               Test Commands: [-fs hdfs://localhost:62624 -touchz /file1]
          2012-03-08 11:10:24,775 INFO ...(163)) -               Test Commands: [-fs hdfs://localhost:62624 -mv /file1 file2]
          2012-03-08 11:10:24,776 INFO ...(167)) - 
          2012-03-08 11:10:24,776 INFO ...(170)) -            Cleanup Commands: [-fs hdfs://localhost:62624 -rm -r /file1]
          2012-03-08 11:10:24,776 INFO ...(174)) - 
          2012-03-08 11:10:24,776 INFO ...(178)) -                  Comparator: [RegexpComparator]
          2012-03-08 11:10:24,779 INFO ...(180)) -          Comparision result:   [fail]
          2012-03-08 11:10:24,779 INFO ...(182)) -             Expected output:   [^mv: `file2': No such file or directory]
          2012-03-08 11:10:24,779 INFO ...(184)) -               Actual output:   [mv: `/file1': Input/output error
          ]
          2012-03-08 11:10:24,779 INFO ...(187)) - 
          2012-03-08 11:10:24,780 INFO ...(156)) - -------------------------------------------
          2012-03-08 11:10:24,780 INFO ...(157)) -                     Test ID: [89]
          2012-03-08 11:10:24,780 INFO ...(158)) -            Test Description: [cp: copying non existent file (relative path)]
          2012-03-08 11:10:24,780 INFO ...(159)) - 
          2012-03-08 11:10:24,780 INFO ...(163)) -               Test Commands: [-fs hdfs://localhost:62624 -cp touchz test]
          2012-03-08 11:10:24,781 INFO ...(163)) -               Test Commands: [-fs hdfs://localhost:62624 -cp file1 file2]
          2012-03-08 11:10:24,781 INFO ...(167)) - 
          2012-03-08 11:10:24,781 INFO ...(170)) -            Cleanup Commands: [-fs hdfs://localhost:62624 -rm -r /user]
          2012-03-08 11:10:24,781 INFO ...(174)) - 
          2012-03-08 11:10:24,781 INFO ...(178)) -                  Comparator: [RegexpComparator]
          2012-03-08 11:10:24,781 INFO ...(180)) -          Comparision result:   [fail]
          2012-03-08 11:10:24,782 INFO ...(182)) -             Expected output:   [^cp: `file2': No such file or directory]
          2012-03-08 11:10:24,782 INFO ...(184)) -               Actual output:   [cp: `file1': No such file or directory
          ]
          
          Show
          Tsz Wo Nicholas Sze added a comment - With hdfs-2038.branch-0.23.2.supplemental.patch, there are still two tests failed. However, it looks like that the actual outputs are correct and the expected outputs are incorrect, i.e. the tests are incorrect. See below. Trunk has a similar problem except that both the expected and actual outputs are incorrect. So that the tests passed. //0.23.2 2012-03-08 11:10:24,774 INFO ...(156)) - ------------------------------------------- 2012-03-08 11:10:24,774 INFO ...(157)) - Test ID: [54] 2012-03-08 11:10:24,775 INFO ...(158)) - Test Description: [mv: file (absolute path) to file (relative path)] 2012-03-08 11:10:24,775 INFO ...(159)) - 2012-03-08 11:10:24,775 INFO ...(163)) - Test Commands: [-fs hdfs://localhost:62624 -touchz /file1] 2012-03-08 11:10:24,775 INFO ...(163)) - Test Commands: [-fs hdfs://localhost:62624 -mv /file1 file2] 2012-03-08 11:10:24,776 INFO ...(167)) - 2012-03-08 11:10:24,776 INFO ...(170)) - Cleanup Commands: [-fs hdfs://localhost:62624 -rm -r /file1] 2012-03-08 11:10:24,776 INFO ...(174)) - 2012-03-08 11:10:24,776 INFO ...(178)) - Comparator: [RegexpComparator] 2012-03-08 11:10:24,779 INFO ...(180)) - Comparision result: [fail] 2012-03-08 11:10:24,779 INFO ...(182)) - Expected output: [^mv: `file2': No such file or directory] 2012-03-08 11:10:24,779 INFO ...(184)) - Actual output: [mv: `/file1': Input/output error ] 2012-03-08 11:10:24,779 INFO ...(187)) - 2012-03-08 11:10:24,780 INFO ...(156)) - ------------------------------------------- 2012-03-08 11:10:24,780 INFO ...(157)) - Test ID: [89] 2012-03-08 11:10:24,780 INFO ...(158)) - Test Description: [cp: copying non existent file (relative path)] 2012-03-08 11:10:24,780 INFO ...(159)) - 2012-03-08 11:10:24,780 INFO ...(163)) - Test Commands: [-fs hdfs://localhost:62624 -cp touchz test] 2012-03-08 11:10:24,781 INFO ...(163)) - Test Commands: [-fs hdfs://localhost:62624 -cp file1 file2] 2012-03-08 11:10:24,781 INFO ...(167)) - 2012-03-08 11:10:24,781 INFO ...(170)) - Cleanup Commands: [-fs hdfs://localhost:62624 -rm -r /user] 2012-03-08 11:10:24,781 INFO ...(174)) - 2012-03-08 11:10:24,781 INFO ...(178)) - Comparator: [RegexpComparator] 2012-03-08 11:10:24,781 INFO ...(180)) - Comparision result: [fail] 2012-03-08 11:10:24,782 INFO ...(182)) - Expected output: [^cp: `file2': No such file or directory] 2012-03-08 11:10:24,782 INFO ...(184)) - Actual output: [cp: `file1': No such file or directory ]
          Hide
          Kihwal Lee added a comment -

          The divergence of 0.23.2 is of no concern, as the PB changes won't go in there.

          Show
          Kihwal Lee added a comment - The divergence of 0.23.2 is of no concern, as the PB changes won't go in there.
          Hide
          Kihwal Lee added a comment -

          Sigh. It's already merged in 23.2.

          The attached patch applies to the current 23.2 (with the trunk patch merged) and fixes the test cases that are failing due to the differences in error messages.

          Show
          Kihwal Lee added a comment - Sigh. It's already merged in 23.2. The attached patch applies to the current 23.2 (with the trunk patch merged) and fixes the test cases that are failing due to the differences in error messages.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I tried to merge the patch to 0.23.2 but the following tests failed. The tests did not fail in 0.23. It may be related to the Protocol Buffer changes.

          2012-03-07 12:06:43,539 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(214)) -              Overall result: --- FAIL ---
          
          2012-03-07 12:06:43,539 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(222)) -                # Tests pass: 593 (98%)
          
          2012-03-07 12:06:43,539 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(224)) -                # Tests fail: 11 (1%)
          
          2012-03-07 12:06:43,539 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(228)) -          # Validations done: 1673 (each test may do multiple validations)
          
          2012-03-07 12:06:43,539 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(231)) - 
          
          2012-03-07 12:06:43,540 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(232)) - Failing tests:
          
          2012-03-07 12:06:43,540 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(233)) - --------------
          
          2012-03-07 12:06:43,540 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 54: mv: file (absolute path) to file (relative path)
          
          2012-03-07 12:06:43,540 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 89: cp: copying non existent file (relative path)
          
          2012-03-07 12:06:43,540 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 565: verifying error messages for quota commands - setting quota on non-existing file
          
          2012-03-07 12:06:43,540 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 569: verifying error messages for quota commands - clearQuota on non existing file
          
          2012-03-07 12:06:43,540 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 570: verifying error messages for quota commands - using globing
          
          2012-03-07 12:06:43,540 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 571: verifying error messages for quota commands - setting quota using globing
          
          2012-03-07 12:06:43,541 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 583: saveNamespace: to save the namespace when safemode is OFF
          
          2012-03-07 12:06:43,541 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 601: Verifying setQuota operation is not permitted in safemode
          
          2012-03-07 12:06:43,541 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 602: Verifying clrQuota operation is not permitted in safemode
          
          2012-03-07 12:06:43,541 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 603: Verifying setSpaceQuota operation is not permitted in safemode
          
          2012-03-07 12:06:43,541 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 604: Verifying clrSpaceQuota operation is not permitted in safemode
          
          Show
          Tsz Wo Nicholas Sze added a comment - I tried to merge the patch to 0.23.2 but the following tests failed. The tests did not fail in 0.23. It may be related to the Protocol Buffer changes. 2012-03-07 12:06:43,539 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(214)) - Overall result: --- FAIL --- 2012-03-07 12:06:43,539 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(222)) - # Tests pass: 593 (98%) 2012-03-07 12:06:43,539 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(224)) - # Tests fail: 11 (1%) 2012-03-07 12:06:43,539 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(228)) - # Validations done: 1673 (each test may do multiple validations) 2012-03-07 12:06:43,539 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(231)) - 2012-03-07 12:06:43,540 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(232)) - Failing tests: 2012-03-07 12:06:43,540 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(233)) - -------------- 2012-03-07 12:06:43,540 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 54: mv: file (absolute path) to file (relative path) 2012-03-07 12:06:43,540 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 89: cp: copying non existent file (relative path) 2012-03-07 12:06:43,540 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 565: verifying error messages for quota commands - setting quota on non-existing file 2012-03-07 12:06:43,540 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 569: verifying error messages for quota commands - clearQuota on non existing file 2012-03-07 12:06:43,540 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 570: verifying error messages for quota commands - using globing 2012-03-07 12:06:43,540 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 571: verifying error messages for quota commands - setting quota using globing 2012-03-07 12:06:43,541 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 583: saveNamespace: to save the namespace when safemode is OFF 2012-03-07 12:06:43,541 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 601: Verifying setQuota operation is not permitted in safemode 2012-03-07 12:06:43,541 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 602: Verifying clrQuota operation is not permitted in safemode 2012-03-07 12:06:43,541 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 603: Verifying setSpaceQuota operation is not permitted in safemode 2012-03-07 12:06:43,541 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(239)) - 604: Verifying clrSpaceQuota operation is not permitted in safemode
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-0.23-Commit #659 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/659/)
          svn merge -c 1298066 from trunk for HDFS-2038. (Revision 1298069)

          Result = SUCCESS
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298069
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestHDFSCLI.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #659 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/659/ ) svn merge -c 1298066 from trunk for HDFS-2038 . (Revision 1298069) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298069 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestHDFSCLI.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #1858 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1858/)
          HDFS-2038. Update TestHDFSCLI to handle relative paths with globs. Contributed by Kihwal Lee (Revision 1298066)

          Result = SUCCESS
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298066
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestHDFSCLI.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1858 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1858/ ) HDFS-2038 . Update TestHDFSCLI to handle relative paths with globs. Contributed by Kihwal Lee (Revision 1298066) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298066 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestHDFSCLI.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #1924 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1924/)
          HDFS-2038. Update TestHDFSCLI to handle relative paths with globs. Contributed by Kihwal Lee (Revision 1298066)

          Result = SUCCESS
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298066
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestHDFSCLI.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1924 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1924/ ) HDFS-2038 . Update TestHDFSCLI to handle relative paths with globs. Contributed by Kihwal Lee (Revision 1298066) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298066 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestHDFSCLI.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #1850 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1850/)
          HDFS-2038. Update TestHDFSCLI to handle relative paths with globs. Contributed by Kihwal Lee (Revision 1298066)

          Result = SUCCESS
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298066
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestHDFSCLI.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1850 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1850/ ) HDFS-2038 . Update TestHDFSCLI to handle relative paths with globs. Contributed by Kihwal Lee (Revision 1298066) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298066 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestHDFSCLI.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-0.23-Commit #658 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/658/)
          svn merge -c 1298066 from trunk for HDFS-2038. (Revision 1298069)

          Result = SUCCESS
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298069
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestHDFSCLI.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #658 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/658/ ) svn merge -c 1298066 from trunk for HDFS-2038 . (Revision 1298069) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298069 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestHDFSCLI.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Commit #649 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/649/)
          svn merge -c 1298066 from trunk for HDFS-2038. (Revision 1298069)

          Result = SUCCESS
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298069
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestHDFSCLI.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #649 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/649/ ) svn merge -c 1298066 from trunk for HDFS-2038 . (Revision 1298069) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298069 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestHDFSCLI.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
          Hide
          Tsz Wo Nicholas Sze added a comment -

          +1 patch looks good. Kihwal and Daryn, thanks a lot for working on this.

          Show
          Tsz Wo Nicholas Sze added a comment - +1 patch looks good. Kihwal and Daryn, thanks a lot for working on this.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12517370/hdfs-2038.patch.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 332 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1961//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1961//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12517370/hdfs-2038.patch.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 332 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1961//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1961//console This message is automatically generated.
          Hide
          Kihwal Lee added a comment -

          The new patch updates the test input xml. Most changes are about relative path handling. Some are related to changes in argument parsing and help message changes.

          Show
          Kihwal Lee added a comment - The new patch updates the test input xml. Most changes are about relative path handling. Some are related to changes in argument parsing and help message changes.
          Hide
          Daryn Sharp added a comment -

          needs rework

          Show
          Daryn Sharp added a comment - needs rework
          Hide
          Daryn Sharp added a comment -

          Kihwal or I will try to work on this mid-late next week. I had a script that did most of the patch translation in the original xml. If I can dig it out, this hopefully won't be a difficult task.

          Show
          Daryn Sharp added a comment - Kihwal or I will try to work on this mid-late next week. I had a script that did most of the patch translation in the original xml. If I can dig it out, this hopefully won't be a difficult task.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Since we are getting no response from Kihwal and Daryn, I will fix this.

          Show
          Tsz Wo Nicholas Sze added a comment - Since we are getting no response from Kihwal and Daryn, I will fix this.
          Hide
          Eli Collins added a comment -

          Kihwal, Daryn - what's the latest? When we ran the test manually there are tons of errors now.

          Bumping priority, not having TestHDFSCLI enabled makes it hard to add new features eg HADOOP-8074.

          Show
          Eli Collins added a comment - Kihwal, Daryn - what's the latest? When we ran the test manually there are tons of errors now. Bumping priority, not having TestHDFSCLI enabled makes it hard to add new features eg HADOOP-8074 .
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Hi Kihwal and Daryn, any update on this?

          Show
          Tsz Wo Nicholas Sze added a comment - Hi Kihwal and Daryn, any update on this?
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #884 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/884/)
          TestHDFSCLI is failing due to HADOOP-7360. HDFS-2038 is going to fix it. Disable it for the moment.

          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1195754
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestHDFSCLI.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #884 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/884/ ) TestHDFSCLI is failing due to HADOOP-7360 . HDFS-2038 is going to fix it. Disable it for the moment. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1195754 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestHDFSCLI.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #850 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/850/)
          TestHDFSCLI is failing due to HADOOP-7360. HDFS-2038 is going to fix it. Disable it for the moment.

          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1195754
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestHDFSCLI.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #850 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/850/ ) TestHDFSCLI is failing due to HADOOP-7360 . HDFS-2038 is going to fix it. Disable it for the moment. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1195754 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestHDFSCLI.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-0.23-Commit #129 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/129/)
          svn merge -c 1195754 from trunk for HDFS-2038.

          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1195755
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestHDFSCLI.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #129 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/129/ ) svn merge -c 1195754 from trunk for HDFS-2038 . szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1195755 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestHDFSCLI.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #1239 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1239/)
          TestHDFSCLI is failing due to HADOOP-7360. HDFS-2038 is going to fix it. Disable it for the moment.

          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1195754
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestHDFSCLI.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1239 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1239/ ) TestHDFSCLI is failing due to HADOOP-7360 . HDFS-2038 is going to fix it. Disable it for the moment. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1195754 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestHDFSCLI.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-0.23-Commit #120 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/120/)
          svn merge -c 1195754 from trunk for HDFS-2038.

          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1195755
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestHDFSCLI.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #120 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/120/ ) svn merge -c 1195754 from trunk for HDFS-2038 . szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1195755 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestHDFSCLI.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Commit #121 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/121/)
          svn merge -c 1195754 from trunk for HDFS-2038.

          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1195755
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestHDFSCLI.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #121 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/121/ ) svn merge -c 1195754 from trunk for HDFS-2038 . szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1195755 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestHDFSCLI.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #1214 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1214/)
          TestHDFSCLI is failing due to HADOOP-7360. HDFS-2038 is going to fix it. Disable it for the moment.

          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1195754
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestHDFSCLI.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1214 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1214/ ) TestHDFSCLI is failing due to HADOOP-7360 . HDFS-2038 is going to fix it. Disable it for the moment. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1195754 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestHDFSCLI.java
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12501713/disable-TestHDFSCLI.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1510//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12501713/disable-TestHDFSCLI.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1510//console This message is automatically generated.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I have committed disable-TestHDFSCLI.patch to 0.23 and trunk. The future patch here should undo the change.

          Show
          Tsz Wo Nicholas Sze added a comment - I have committed disable-TestHDFSCLI.patch to 0.23 and trunk. The future patch here should undo the change.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #1290 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1290/)
          TestHDFSCLI is failing due to HADOOP-7360. HDFS-2038 is going to fix it. Disable it for the moment.

          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1195754
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestHDFSCLI.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1290 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1290/ ) TestHDFSCLI is failing due to HADOOP-7360 . HDFS-2038 is going to fix it. Disable it for the moment. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1195754 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/cli/TestHDFSCLI.java
          Hide
          Jitendra Nath Pandey added a comment -

          +1 for the patch disabling the test. But we should keep the jira open to fix this issue.

          Show
          Jitendra Nath Pandey added a comment - +1 for the patch disabling the test. But we should keep the jira open to fix this issue.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Kihwal and Daryn, I understand that you are fixing the tests. Let's temporarily disable the test. Otherwise, it is going to break every build and we cannot release 0.23.

          disable-TestHDFSCLI.patch: temporarily disble the test.

          Show
          Tsz Wo Nicholas Sze added a comment - Kihwal and Daryn, I understand that you are fixing the tests. Let's temporarily disable the test. Otherwise, it is going to break every build and we cannot release 0.23. disable-TestHDFSCLI.patch: temporarily disble the test.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12486100/HDFS-2038-2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 262 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1503//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12486100/HDFS-2038-2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 262 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1503//console This message is automatically generated.
          Hide
          Daryn Sharp added a comment -

          This patch will fail until the linked HADOOP-7360 is committed.

          Show
          Daryn Sharp added a comment - This patch will fail until the linked HADOOP-7360 is committed.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12486100/HDFS-2038-2.patch
          against trunk revision 1145753.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 262 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these core unit tests:
          org.apache.hadoop.cli.TestHDFSCLI

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/912//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/912//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/912//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12486100/HDFS-2038-2.patch against trunk revision 1145753. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 262 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.cli.TestHDFSCLI +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/912//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/912//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/912//console This message is automatically generated.
          Hide
          Aaron T. Myers added a comment -

          For some reason the pre-commit build for this latest patch was aborted by Hudson. I just kicked off another build.

          Show
          Aaron T. Myers added a comment - For some reason the pre-commit build for this latest patch was aborted by Hudson. I just kicked off another build.
          Hide
          Daryn Sharp added a comment -

          Updated more tests to use NAMENODE instead of fuzzy regexp in the expected-output
          Ls output now has same behavior as all other commands.

          Show
          Daryn Sharp added a comment - Updated more tests to use NAMENODE instead of fuzzy regexp in the expected-output Ls output now has same behavior as all other commands.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12481541/HDFS-2038.patch
          against trunk revision 1132525.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 135 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these core unit tests:
          org.apache.hadoop.cli.TestHDFSCLI

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/713//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/713//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/713//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12481541/HDFS-2038.patch against trunk revision 1132525. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 135 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.cli.TestHDFSCLI +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/713//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/713//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/713//console This message is automatically generated.

            People

            • Assignee:
              Kihwal Lee
              Reporter:
              Daryn Sharp
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development