Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0, 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      A few of the HDFS tests (not intended to test deprecation) use config keys which are deprecated.

      1. hdfs-1999.0.patch
        23 kB
        Aaron T. Myers
      2. hdfs-1999.1.patch
        23 kB
        Aaron T. Myers

        Activity

        Hide
        Aaron T. Myers added a comment -

        Patch for trunk which replaces all references to deprecated config keys (including comments) in src/test/* with the corresponding superseding keys.

        Show
        Aaron T. Myers added a comment - Patch for trunk which replaces all references to deprecated config keys (including comments) in src/test/* with the corresponding superseding keys.
        Hide
        Eli Collins added a comment -

        The tests should use DFSConfigKeys, otherwise looks great.

        Show
        Eli Collins added a comment - The tests should use DFSConfigKeys, otherwise looks great.
        Hide
        Aaron T. Myers added a comment -

        Thanks a lot for the review, Eli. Attached is a patch addressing your comments.

        Show
        Aaron T. Myers added a comment - Thanks a lot for the review, Eli. Attached is a patch addressing your comments.
        Hide
        Eli Collins added a comment -

        +1 pending Hudson

        Show
        Eli Collins added a comment - +1 pending Hudson
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12480512/hdfs-1999.0.patch
        against trunk revision 1127759.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 47 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
        org.apache.hadoop.hdfs.TestQuota

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/629//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/629//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/629//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12480512/hdfs-1999.0.patch against trunk revision 1127759. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 47 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.TestDFSStorageStateRecovery org.apache.hadoop.hdfs.TestQuota +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/629//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/629//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/629//console This message is automatically generated.
        Hide
        Eli Collins added a comment -

        The TestQuota timeout is unrelated.

        Show
        Eli Collins added a comment - The TestQuota timeout is unrelated.
        Hide
        Eli Collins added a comment -

        I've committed this. Thanks atm!

        Show
        Eli Collins added a comment - I've committed this. Thanks atm!
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12480512/hdfs-1999.0.patch
        against trunk revision 1127759.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 47 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
        org.apache.hadoop.hdfs.TestFileAppend4
        org.apache.hadoop.hdfs.TestLargeBlock
        org.apache.hadoop.hdfs.TestWriteConfigurationToDFS

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/627//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/627//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/627//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12480512/hdfs-1999.0.patch against trunk revision 1127759. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 47 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.TestDFSStorageStateRecovery org.apache.hadoop.hdfs.TestFileAppend4 org.apache.hadoop.hdfs.TestLargeBlock org.apache.hadoop.hdfs.TestWriteConfigurationToDFS +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/627//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/627//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/627//console This message is automatically generated.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #678 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/678/)
        HDFS-1999. Tests use deprecated configs. Contributed by Aaron T. Myers

        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1127823
        Files :

        • /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestSafeMode.java
        • /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/hadoop-dfs-dir.txt
        • /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/metrics/TestNameNodeMetrics.java
        • /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/datanode/TestDiskError.java
        • /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/UpgradeUtilities.java
        • /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/CreateEditsLog.java
        • /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestBackupNode.java
        • /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestStartup.java
        • /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/TestHDFSServerPorts.java
        • /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/TestSafeMode.java
        • /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/MiniDFSCluster.java
        • /hadoop/hdfs/trunk/src/test/system/java/org/apache/hadoop/hdfs/test/system/HDFSDaemonClient.java
        • /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestStorageRestore.java
        • /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestNameEditsConfigs.java
        • /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/TestDFSStorageStateRecovery.java
        • /hadoop/hdfs/trunk/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #678 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/678/ ) HDFS-1999 . Tests use deprecated configs. Contributed by Aaron T. Myers eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1127823 Files : /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestSafeMode.java /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/hadoop-dfs-dir.txt /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/metrics/TestNameNodeMetrics.java /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/datanode/TestDiskError.java /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/UpgradeUtilities.java /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/CreateEditsLog.java /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestBackupNode.java /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestStartup.java /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/TestHDFSServerPorts.java /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/TestSafeMode.java /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/MiniDFSCluster.java /hadoop/hdfs/trunk/src/test/system/java/org/apache/hadoop/hdfs/test/system/HDFSDaemonClient.java /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestStorageRestore.java /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestNameEditsConfigs.java /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/TestDFSStorageStateRecovery.java /hadoop/hdfs/trunk/CHANGES.txt
        Hide
        Todd Lipcon added a comment -

        Looks like this commit broke the system test compilation. I'm not sure why Hudson QA gave it a +1. I will fix this in-place since it's just a missing import.

        Show
        Todd Lipcon added a comment - Looks like this commit broke the system test compilation. I'm not sure why Hudson QA gave it a +1. I will fix this in-place since it's just a missing import.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #688 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/688/)
        Amend HDFS-1999: missing import in system tests

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1127966
        Files :

        • /hadoop/hdfs/trunk/src/test/system/java/org/apache/hadoop/hdfs/test/system/HDFSDaemonClient.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #688 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/688/ ) Amend HDFS-1999 : missing import in system tests todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1127966 Files : /hadoop/hdfs/trunk/src/test/system/java/org/apache/hadoop/hdfs/test/system/HDFSDaemonClient.java
        Hide
        Tsz Wo Nicholas Sze added a comment -

        > ... I'm not sure why Hudson QA gave it a +1. ...

        System test seems not working for a long time.

        Show
        Tsz Wo Nicholas Sze added a comment - > ... I'm not sure why Hudson QA gave it a +1. ... System test seems not working for a long time.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #679 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/679/)
        Amend HDFS-1999: missing import in system tests

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1127966
        Files :

        • /hadoop/hdfs/trunk/src/test/system/java/org/apache/hadoop/hdfs/test/system/HDFSDaemonClient.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #679 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/679/ ) Amend HDFS-1999 : missing import in system tests todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1127966 Files : /hadoop/hdfs/trunk/src/test/system/java/org/apache/hadoop/hdfs/test/system/HDFSDaemonClient.java

          People

          • Assignee:
            Aaron T. Myers
            Reporter:
            Aaron T. Myers
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development