Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1912

Update tests for FsShell standardized error messages

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Need to update the FsShell based tests for commonized error messages.

      1. HDFS-1912.patch
        48 kB
        Daryn Sharp

        Issue Links

          Activity

          Daryn Sharp created issue -
          Daryn Sharp made changes -
          Field Original Value New Value
          Link This issue depends on HADOOP-7271 [ HADOOP-7271 ]
          Hide
          Daryn Sharp added a comment -

          Updated tests

          Show
          Daryn Sharp added a comment - Updated tests
          Daryn Sharp made changes -
          Attachment HDFS-1912.patch [ 12478718 ]
          Hide
          Aaron T. Myers added a comment -

          +1. The attached patch looks good to me.

          Show
          Aaron T. Myers added a comment - +1. The attached patch looks good to me.
          Daryn Sharp made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12478718/HDFS-1912.patch
          against trunk revision 1101753.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 139 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these core unit tests:
          org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
          org.apache.hadoop.hdfs.TestFileConcurrentReader
          org.apache.hadoop.tools.TestJMXGet

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/481//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/481//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/481//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12478718/HDFS-1912.patch against trunk revision 1101753. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 139 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.TestDFSStorageStateRecovery org.apache.hadoop.hdfs.TestFileConcurrentReader org.apache.hadoop.tools.TestJMXGet +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/481//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/481//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/481//console This message is automatically generated.
          Hide
          Daryn Sharp added a comment -

          Test failures are unrelated to this patch.

          Show
          Daryn Sharp added a comment - Test failures are unrelated to this patch.
          Daryn Sharp made changes -
          Link This issue blocks HDFS-1903 [ HDFS-1903 ]
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I have committed this. Thanks, Daryn!

          Also thanks Aaron for reviewing it.

          Show
          Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Daryn! Also thanks Aaron for reviewing it.
          Tsz Wo Nicholas Sze made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Fix Version/s 0.23.0 [ 12315571 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #637 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/637/)
          HDFS-1912. Update tests for FsShell standardized error messages. Contributed by Daryn Sharp

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #637 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/637/ ) HDFS-1912 . Update tests for FsShell standardized error messages. Contributed by Daryn Sharp
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #673 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/673/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #673 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/673/ )
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Gavin made changes -
          Link This issue depends on HADOOP-7271 [ HADOOP-7271 ]
          Gavin made changes -
          Link This issue depends upon HADOOP-7271 [ HADOOP-7271 ]

            People

            • Assignee:
              Daryn Sharp
              Reporter:
              Daryn Sharp
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development