Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1889

incorrect path in start/stop dfs script

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HADOOP_HOME in start-dfs.sh and stop-dfs.sh should be changed to HADOOP_HDFS_HOME because hdfs script is in the hdfs
      directory and not common directory

      1. HDFS-1889-1.patch
        3 kB
        John George
      2. HDFS-1889.patch
        2 kB
        John George

        Activity

        Hide
        John George added a comment -

        Attaching patch. No tests added since this tests the scripts that start and stop hadoop.

        Show
        John George added a comment - Attaching patch. No tests added since this tests the scripts that start and stop hadoop.
        Hide
        Eli Collins added a comment -

        Hey John,

        I think we need to make this change in a number of places. I think federation added a bunch of uses of HADOOP_HOME that should be HADOOP_HDFS_HOME:

        On trunk pre-federation:

        hdfs2 (branch-0.22)$ grep -r HADOOP_HOME bin/
        bin/hdfs-config.sh:elif [ -d "${HADOOP_HOME}" ]; then
        bin/hdfs-config.sh:  . "$HADOOP_HOME"/bin/hadoop-config.sh
        

        On trunk:

        hdfs2 (branch-0.22)$ c trunk
        Switched to branch 'trunk'
        hdfs2 (trunk)$ grep -r HADOOP_HOME bin/
        bin/hdfs-config.sh:elif [ -d "${HADOOP_HOME}" ]; then
        bin/hdfs-config.sh:  . "$HADOOP_HOME"/bin/hadoop-config.sh
        bin/stop-dfs.sh:NAMENODES=$($HADOOP_HOME/bin/hdfs getconf -namenodes)
        bin/stop-dfs.sh:SECONDARY_NAMENODES=$($HADOOP_HOME/bin/hdfs getconf -secondarynamenodes 2>&-)
        bin/start-dfs.sh:NAMENODES=$($HADOOP_HOME/bin/hdfs getconf -namenodes)
        bin/start-dfs.sh:SECONDARY_NAMENODES=$($HADOOP_HOME/bin/hdfs getconf -secondarynamenodes 2>&-)
        bin/refresh-namenodes.sh:namenodes=$("$HADOOP_HOME/bin/hdfs" getconf -namenodes)
        bin/refresh-namenodes.sh:  "$HADOOP_HOME/bin/hdfs" dfsadmin -refreshNodes
        bin/distribute-exclude.sh:namenodes=$("$HADOOP_HOME/bin/hdfs" getconf -namenodes)
        bin/distribute-exclude.sh:excludeFilenameRemote=$("$HADOOP_HOME/bin/hdfs" getconf -excludeFile)
        
        Show
        Eli Collins added a comment - Hey John, I think we need to make this change in a number of places. I think federation added a bunch of uses of HADOOP_HOME that should be HADOOP_HDFS_HOME: On trunk pre-federation: hdfs2 (branch-0.22)$ grep -r HADOOP_HOME bin/ bin/hdfs-config.sh:elif [ -d "${HADOOP_HOME}" ]; then bin/hdfs-config.sh: . "$HADOOP_HOME"/bin/hadoop-config.sh On trunk: hdfs2 (branch-0.22)$ c trunk Switched to branch 'trunk' hdfs2 (trunk)$ grep -r HADOOP_HOME bin/ bin/hdfs-config.sh:elif [ -d "${HADOOP_HOME}" ]; then bin/hdfs-config.sh: . "$HADOOP_HOME"/bin/hadoop-config.sh bin/stop-dfs.sh:NAMENODES=$($HADOOP_HOME/bin/hdfs getconf -namenodes) bin/stop-dfs.sh:SECONDARY_NAMENODES=$($HADOOP_HOME/bin/hdfs getconf -secondarynamenodes 2>&-) bin/start-dfs.sh:NAMENODES=$($HADOOP_HOME/bin/hdfs getconf -namenodes) bin/start-dfs.sh:SECONDARY_NAMENODES=$($HADOOP_HOME/bin/hdfs getconf -secondarynamenodes 2>&-) bin/refresh-namenodes.sh:namenodes=$("$HADOOP_HOME/bin/hdfs" getconf -namenodes) bin/refresh-namenodes.sh: "$HADOOP_HOME/bin/hdfs" dfsadmin -refreshNodes bin/distribute-exclude.sh:namenodes=$("$HADOOP_HOME/bin/hdfs" getconf -namenodes) bin/distribute-exclude.sh:excludeFilenameRemote=$("$HADOOP_HOME/bin/hdfs" getconf -excludeFile)
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12478185/HDFS-1889.patch
        against trunk revision 1099525.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/450//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/450//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/450//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12478185/HDFS-1889.patch against trunk revision 1099525. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/450//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/450//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/450//console This message is automatically generated.
        Hide
        John George added a comment -

        Good point Eli. Changing (reverting to pre- federation) all hdfs/bin directory references from HADOOP_HOME/bin/hdfs to HADOOP_HDFS_HOME/bin/hdfs.

        Show
        John George added a comment - Good point Eli. Changing (reverting to pre- federation) all hdfs/bin directory references from HADOOP_HOME/bin/hdfs to HADOOP_HDFS_HOME/bin/hdfs.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12478201/HDFS-1889-1.patch
        against trunk revision 1099525.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.hdfs.server.namenode.TestBackupNode
        org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
        org.apache.hadoop.hdfs.TestFileConcurrentReader

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/452//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/452//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/452//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12478201/HDFS-1889-1.patch against trunk revision 1099525. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.server.namenode.TestBackupNode org.apache.hadoop.hdfs.TestDFSStorageStateRecovery org.apache.hadoop.hdfs.TestFileConcurrentReader +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/452//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/452//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/452//console This message is automatically generated.
        Hide
        Eli Collins added a comment -

        +1 lgtm. test failures are unrelated.

        Show
        Eli Collins added a comment - +1 lgtm. test failures are unrelated.
        Hide
        Eli Collins added a comment -

        I've committed this. Thanks John!

        Show
        Eli Collins added a comment - I've committed this. Thanks John!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #673 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/673/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #673 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/673/ )

          People

          • Assignee:
            John George
            Reporter:
            John George
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development