Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1862

Improve test reliability of HDFS-1594

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      One of the tests I wrote in HDFS-1594 seems to be flaky in Hudson runs, despite passing reliably on my box. This JIRA is to track improving the reliability of this test.

      1. hdfs-1862.0.patch
        4 kB
        Aaron T. Myers

        Activity

        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #650 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/650/)
        HDFS-1862. Improve test reliability of HDFS-1594. Contributed by Aaron T. Myers

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #650 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/650/ ) HDFS-1862 . Improve test reliability of HDFS-1594 . Contributed by Aaron T. Myers
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #610 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/610/)
        HDFS-1862. Improve test reliability of HDFS-1594. Contributed by Aaron T. Myers

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #610 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/610/ ) HDFS-1862 . Improve test reliability of HDFS-1594 . Contributed by Aaron T. Myers
        Eli Collins made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Hide
        Eli Collins added a comment -

        Yes those are unrelated.

        I've committed this. Thanks atm!

        Show
        Eli Collins added a comment - Yes those are unrelated. I've committed this. Thanks atm!
        Hide
        Aaron T. Myers added a comment -

        I'm pretty sure the failing tests are unrelated to this patch.

        Show
        Aaron T. Myers added a comment - I'm pretty sure the failing tests are unrelated to this patch.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12477470/hdfs-1862.0.patch
        against trunk revision 1096974.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.hdfs.TestFileAppend4
        org.apache.hadoop.hdfs.TestFileConcurrentReader
        org.apache.hadoop.hdfs.TestLargeBlock
        org.apache.hadoop.hdfs.TestWriteConfigurationToDFS

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/420//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/420//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/420//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12477470/hdfs-1862.0.patch against trunk revision 1096974. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.TestFileAppend4 org.apache.hadoop.hdfs.TestFileConcurrentReader org.apache.hadoop.hdfs.TestLargeBlock org.apache.hadoop.hdfs.TestWriteConfigurationToDFS +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/420//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/420//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/420//console This message is automatically generated.
        Hide
        Eli Collins added a comment -

        +1 looks good to me too.

        Show
        Eli Collins added a comment - +1 looks good to me too.
        Hide
        Konstantin Boudnik added a comment -

        +1 patch looks good.

        Show
        Konstantin Boudnik added a comment - +1 patch looks good.
        Aaron T. Myers made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Aaron T. Myers made changes -
        Field Original Value New Value
        Attachment hdfs-1862.0.patch [ 12477470 ]
        Hide
        Aaron T. Myers added a comment -

        Patch which mocks out the NameNodeResourceChecker to exercise the NameNodeResourceMonitor thread. This change removes the test's reliance on the state of the local disk.

        Show
        Aaron T. Myers added a comment - Patch which mocks out the NameNodeResourceChecker to exercise the NameNodeResourceMonitor thread. This change removes the test's reliance on the state of the local disk.
        Aaron T. Myers created issue -

          People

          • Assignee:
            Aaron T. Myers
            Reporter:
            Aaron T. Myers
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development