Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1844

Move -fs usage tests from hdfs into common

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The -fs usage tests are in hdfs which causes an unnecessary synchronization of a common & hdfs bug when changing the text. The usages have no ties to hdfs, so they should be moved into common.

      1. HDFS-1844.patch
        29 kB
        Daryn Sharp

        Issue Links

          Activity

          Hide
          Daryn Sharp added a comment -

          Remove tests that are moving to common.

          Show
          Daryn Sharp added a comment - Remove tests that are moving to common.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12476638/HDFS-1844.patch
          against trunk revision 1094092.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 60 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these core unit tests:
          org.apache.hadoop.hdfs.TestDFSRollback

          -1 contrib tests. The patch failed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/379//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/379//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/379//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12476638/HDFS-1844.patch against trunk revision 1094092. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 60 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.TestDFSRollback -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/379//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/379//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/379//console This message is automatically generated.
          Hide
          Aaron T. Myers added a comment -

          Thanks a lot for this, Daryn. I've reviewed the code and it looks good to me.

          Show
          Aaron T. Myers added a comment - Thanks a lot for this, Daryn. I've reviewed the code and it looks good to me.
          Hide
          Daryn Sharp added a comment -

          Note: the failed tests are not related to this change.

          Show
          Daryn Sharp added a comment - Note: the failed tests are not related to this change.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Hi Aaron, if you think the patch is good, could you +1, and check "reviewed" box by editing the JIRA? Please do the same for HADOOP-7230.

          Show
          Tsz Wo Nicholas Sze added a comment - Hi Aaron, if you think the patch is good, could you +1, and check "reviewed" box by editing the JIRA? Please do the same for HADOOP-7230 .
          Hide
          Aaron T. Myers added a comment -

          Happy to, Nicholas.

          +1

          Show
          Aaron T. Myers added a comment - Happy to, Nicholas. +1
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Aaron, thanks a lot for the fast response!

          Show
          Tsz Wo Nicholas Sze added a comment - Aaron, thanks a lot for the fast response!
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I have committed this. Thanks, Daryn!

          Show
          Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Daryn!
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #643 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/643/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #643 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/643/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #600 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/600/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #600 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/600/ )

            People

            • Assignee:
              Daryn Sharp
              Reporter:
              Daryn Sharp
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development