Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      Removed thriftfs contrib component.

      Description

      As per vote on general@ (http://mail-archives.apache.org/mod_mbox/hadoop-general/201102.mbox/%3CEF44CFE2-692F-4956-8B33-D125D05E2B53@mac.com%3E) thriftfs can be removed:
      svn remove hdfs/trunk/src/contrib/thriftfs
      and wiki updated:
      http://wiki.apache.org/hadoop/Attic

      1. HDFS-1825.patch
        1.11 MB
        Nigel Daley

        Activity

        Nigel Daley created issue -
        Hide
        Eli Collins added a comment -

        +1

        Can also close out these jiras:
        project = HDFS and resolution = Unresolved and component = "contrib/thriftfs"

        Show
        Eli Collins added a comment - +1 Can also close out these jiras: project = HDFS and resolution = Unresolved and component = "contrib/thriftfs"
        Hide
        dhruba borthakur added a comment -

        +1

        Show
        dhruba borthakur added a comment - +1
        Hide
        Nigel Daley added a comment -

        Patch that removes thriftfs and it's build references.

        Show
        Nigel Daley added a comment - Patch that removes thriftfs and it's build references.
        Nigel Daley made changes -
        Field Original Value New Value
        Attachment HDFS-1825.patch [ 12477192 ]
        Nigel Daley made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Release Note Removed thriftfs contrib component.
        Assignee Nigel Daley [ nidaley ]
        Hide
        Eli Collins added a comment -

        Needs the following minor tweak to get ant clean to run cleanly, but otherwise looks great.

           <!-- ====================================================== -->
           <!-- Clean all the contribs.                              -->
           <!-- ====================================================== -->
           <target name="clean">
             <subant target="clean">
        -      <fileset dir="." includes="*/build.xml"/>
        +      <fileset dir="." includes="hdfsproxy/build.xml"/>
             </subant>
           </target>
        
        Show
        Eli Collins added a comment - Needs the following minor tweak to get ant clean to run cleanly, but otherwise looks great. <!-- ====================================================== --> <!-- Clean all the contribs. --> <!-- ====================================================== --> <target name="clean"> <subant target="clean"> - <fileset dir="." includes="*/build.xml"/> + <fileset dir="." includes="hdfsproxy/build.xml"/> </subant> </target>
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12477192/HDFS-1825.patch
        against trunk revision 1096010.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 4 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        -1 release audit. The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings).

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.hdfs.TestFileAppend4
        org.apache.hadoop.hdfs.TestFileConcurrentReader
        org.apache.hadoop.hdfs.TestLargeBlock
        org.apache.hadoop.hdfs.TestWriteConfigurationToDFS

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/412//testReport/
        Release audit warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/412//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/412//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/412//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12477192/HDFS-1825.patch against trunk revision 1096010. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. -1 release audit. The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings). -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.TestFileAppend4 org.apache.hadoop.hdfs.TestFileConcurrentReader org.apache.hadoop.hdfs.TestLargeBlock org.apache.hadoop.hdfs.TestWriteConfigurationToDFS +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/412//testReport/ Release audit warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/412//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/412//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/412//console This message is automatically generated.
        Hide
        Nigel Daley added a comment -

        Thanks for looking at this patch Eli. I don't see a problem running ant clean using the current patch. Also, doesn't your suggestion then remove clean support for fuse-dfs?

        Show
        Nigel Daley added a comment - Thanks for looking at this patch Eli. I don't see a problem running ant clean using the current patch. Also, doesn't your suggestion then remove clean support for fuse-dfs?
        Hide
        Eli Collins added a comment -

        Weird. When I apply your patch on a fresh svn tree and run ant clean I get the following. Works for you?

        BUILD FAILED
        /home/eli/src/hdfs-trunk/build.xml:1272: The following error occurred while executing this line:
        /home/eli/src/hdfs-trunk/src/contrib/build.xml:59: The following error occurred while executing this line:
        Premature end of file.
        
        Show
        Eli Collins added a comment - Weird. When I apply your patch on a fresh svn tree and run ant clean I get the following. Works for you? BUILD FAILED /home/eli/src/hdfs-trunk/build.xml:1272: The following error occurred while executing this line: /home/eli/src/hdfs-trunk/src/contrib/build.xml:59: The following error occurred while executing this line: Premature end of file.
        Hide
        Eli Collins added a comment -

        Was an issue with the way the patch applied. Works for me now. +1

        I've committed this to trunk and merged to 22. Thanks Nigel!

        Show
        Eli Collins added a comment - Was an issue with the way the patch applied. Works for me now. +1 I've committed this to trunk and merged to 22. Thanks Nigel!
        Eli Collins made changes -
        Hadoop Flags [Incompatible change] [Incompatible change, Reviewed]
        Fix Version/s 0.22.0 [ 12314241 ]
        Fix Version/s 0.23.0 [ 12315571 ]
        Eli Collins made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #658 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/658/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #658 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/658/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-22-branch #49 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-22-branch/49/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-22-branch #49 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-22-branch/49/ )
        Hide
        Nigel Daley added a comment -

        Just removed contrib/thriftfs from Jira and add to the Attic wiki: http://wiki.apache.org/hadoop/Attic

        Show
        Nigel Daley added a comment - Just removed contrib/thriftfs from Jira and add to the Attic wiki: http://wiki.apache.org/hadoop/Attic
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #673 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/673/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #673 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/673/ )
        Konstantin Shvachko made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Chu Tong added a comment -

        After removing hdfs thrift server, is there any alternative to access hdfs via thrift like service?

        Show
        Chu Tong added a comment - After removing hdfs thrift server, is there any alternative to access hdfs via thrift like service?

          People

          • Assignee:
            Nigel Daley
            Reporter:
            Nigel Daley
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development