[HDFS-1820] FTPFileSystem attempts to close the outputstream even when it is not initialised

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.20.1
• Fix Version/s: 3.3.1
• Component/s: hdfs-client
• Labels: hadoop

Environment

occurs on all platforms

• Tags: FTPFileSystem FTPClient file permissions
• Assignee: Mikhail Pryakhin
• Reporter: Sudharsan Sampath
• Created: 08/Apr/11 11:10
• Updated: 11/May/20 13:46
• Resolved: 11/May/20 13:46

Description

FTPFileSystem's create method attempts to close the outputstream even when it is not initialized causing a null pointer exception. In our case the apache commons FTPClient was not able to create the destination file due to permissions issue. The FtpClient promptly reported a 553 : Permissions issue but it was overlooked in FTPFileSystem create method.

The following code fails

if (!FTPReply.isPositivePreliminary(client.getReplyCode()))

{ // The ftpClient is an inconsistent state. Must close the stream // which in turn will logout and disconnect from FTP server fos.close(); throw new IOException("Unable to create file: " + file + ", Aborting"); }

as 'fos' is null. As a result the proper error message "Unable to create file XXX" is not reported but rather a null pointer exception.

Issue Links

• breaks: HADOOP-17036 TestFTPFileSystem failing as ftp server dir already exists
• links to: GitHub Pull Request #1952