Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1814

HDFS portion of HADOOP-7214 - Hadoop /usr/bin/groups equivalent

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: hdfs-client, namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Introduces a new command, "hdfs groups", which displays what groups are associated with a user as seen by the NameNode.
    1. hdfs-1814.0.txt
      10 kB
      Aaron T. Myers
    2. hdfs-1814.1.txt
      10 kB
      Aaron T. Myers
    3. hdfs-1814.2.txt
      9 kB
      Aaron T. Myers
    4. hdfs-1814.3.patch
      13 kB
      Aaron T. Myers
    5. hdfs-1814.4.patch
      10 kB
      Aaron T. Myers
    6. hdfs-1814.5.patch
      10 kB
      Aaron T. Myers

      Issue Links

        Activity

        Hide
        Aaron T. Myers added a comment -

        Patch providing the HDFS implementation of "hadoop fs -groups" command.

        Show
        Aaron T. Myers added a comment - Patch providing the HDFS implementation of "hadoop fs -groups" command.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12475653/hdfs-1814.0.txt
        against trunk revision 1087900.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 20 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        -1 javac. The patch appears to cause tar ant target to fail.

        -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:

        -1 contrib tests. The patch failed contrib unit tests.

        -1 system test framework. The patch failed system test framework compile.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/323//testReport/
        Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/323//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12475653/hdfs-1814.0.txt against trunk revision 1087900. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 20 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: -1 contrib tests. The patch failed contrib unit tests. -1 system test framework. The patch failed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/323//testReport/ Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/323//console This message is automatically generated.
        Hide
        Aaron T. Myers added a comment -

        Not surprising it failed to compile - it depends upon HADOOP-7214. I'll post the results of a manual test run shortly.

        Show
        Aaron T. Myers added a comment - Not surprising it failed to compile - it depends upon HADOOP-7214 . I'll post the results of a manual test run shortly.
        Hide
        Daryn Sharp added a comment -

        Should a configuration be passed to getGroupsMappingService()?

        On a side note, I've been troubled by FsShell (in common) having tests in hdfs. It creates an entanglement of jira cross-dependencies. I'd suggest adding unit tests for the namenode in hdfs, and adding the functional tests of FsShell to common.

        Show
        Daryn Sharp added a comment - Should a configuration be passed to getGroupsMappingService()? On a side note, I've been troubled by FsShell (in common) having tests in hdfs. It creates an entanglement of jira cross-dependencies. I'd suggest adding unit tests for the namenode in hdfs, and adding the functional tests of FsShell to common.
        Hide
        Aaron T. Myers added a comment -

        Should a configuration be passed to getGroupsMappingService()?

        I'm afraid I don't follow. Why would this be necessary or desirable?

        On a side note, I've been troubled by FsShell (in common) having tests in hdfs. It creates an entanglement of jira cross-dependencies. I'd suggest adding unit tests for the namenode in hdfs, and adding the functional tests of FsShell to common.

        I totally agree that we should tease these apart. Can we file this as a separate issue, though?

        Show
        Aaron T. Myers added a comment - Should a configuration be passed to getGroupsMappingService()? I'm afraid I don't follow. Why would this be necessary or desirable? On a side note, I've been troubled by FsShell (in common) having tests in hdfs. It creates an entanglement of jira cross-dependencies. I'd suggest adding unit tests for the namenode in hdfs, and adding the functional tests of FsShell to common. I totally agree that we should tease these apart. Can we file this as a separate issue, though?
        Hide
        Aaron T. Myers added a comment -

        The results of running test-patch against a trunk build containing the patch from HADOOP-7214:

        [exec] +1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] +1 tests included. The patch appears to include 20 new or modified tests.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
        [exec]
        [exec] +1 system test framework. The patch passed system test framework compile.

        I'm running the full test suite now. Will post the results when that's done.

        Show
        Aaron T. Myers added a comment - The results of running test-patch against a trunk build containing the patch from HADOOP-7214 : [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 20 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system test framework. The patch passed system test framework compile. I'm running the full test suite now. Will post the results when that's done.
        Hide
        Daryn Sharp added a comment -

        I suggested passing the config because it can accept a config. Although it doesn't appear to be used currently, it might someday... Perhaps someone else can comment.

        I was just lamenting the current test situation, so I'm fine with a separate bug for the tests.

        Show
        Daryn Sharp added a comment - I suggested passing the config because it can accept a config. Although it doesn't appear to be used currently, it might someday... Perhaps someone else can comment. I was just lamenting the current test situation, so I'm fine with a separate bug for the tests.
        Hide
        Aaron T. Myers added a comment -

        Just finished running the full test suite. The only failures were:

        org.apache.hadoop.hdfs.server.datanode.TestBlockReport
        org.apache.hadoop.hdfs.TestFileConcurrentReader
        org.apache.hadoop.hdfs.TestDFSShell

        All of these are presently failing on trunk. Since TestDFSShell is pertinent to this patch, I manually verified that the failure is for the same reason that it's failing on trunk.

        Show
        Aaron T. Myers added a comment - Just finished running the full test suite. The only failures were: org.apache.hadoop.hdfs.server.datanode.TestBlockReport org.apache.hadoop.hdfs.TestFileConcurrentReader org.apache.hadoop.hdfs.TestDFSShell All of these are presently failing on trunk. Since TestDFSShell is pertinent to this patch, I manually verified that the failure is for the same reason that it's failing on trunk.
        Hide
        Aaron T. Myers added a comment -

        I just re-ran TestDFSShell after the commit of HADOOP-7216, which fixes the TestDFSShell failure.

        Show
        Aaron T. Myers added a comment - I just re-ran TestDFSShell after the commit of HADOOP-7216 , which fixes the TestDFSShell failure.
        Hide
        Daryn Sharp added a comment -

        Out of curiosity, why do the tests appear to except trailing whitespace in the output?

        As cited in the common side of this bug, user existence appears to be: if UserGroupInformation.isSecurityEnabled() is true, then an empty group list means "No such user"

        Show
        Daryn Sharp added a comment - Out of curiosity, why do the tests appear to except trailing whitespace in the output? As cited in the common side of this bug, user existence appears to be: if UserGroupInformation.isSecurityEnabled() is true, then an empty group list means "No such user"
        Hide
        Aaron T. Myers added a comment -

        Thanks a lot for the review, Daryn.

        Out of curiosity, why do the tests appear to except trailing whitespace in the output?

        I'm not sure of the original motivation for that. I just made my tests mimic those already in the file.

        Show
        Aaron T. Myers added a comment - Thanks a lot for the review, Daryn. Out of curiosity, why do the tests appear to except trailing whitespace in the output? I'm not sure of the original motivation for that. I just made my tests mimic those already in the file.
        Hide
        Daryn Sharp added a comment -

        Ok. I'll eventually be making a sweep over that test file as part of the FsShell redesign, so I suppose consistency at that this point is ok.

        +1

        Show
        Daryn Sharp added a comment - Ok. I'll eventually be making a sweep over that test file as part of the FsShell redesign, so I suppose consistency at that this point is ok. +1
        Hide
        Aaron T. Myers added a comment -

        Updated patch rebased against trunk.

        Show
        Aaron T. Myers added a comment - Updated patch rebased against trunk.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12476586/hdfs-1814.1.txt
        against trunk revision 1094092.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 20 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        -1 javac. The patch appears to cause tar ant target to fail.

        -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:

        -1 contrib tests. The patch failed contrib unit tests.

        -1 system test framework. The patch failed system test framework compile.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/378//testReport/
        Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/378//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12476586/hdfs-1814.1.txt against trunk revision 1094092. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 20 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: -1 contrib tests. The patch failed contrib unit tests. -1 system test framework. The patch failed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/378//testReport/ Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/378//console This message is automatically generated.
        Hide
        Aaron T. Myers added a comment -

        Rebase patch against trunk. Moves the tests for -help into common from HDFS per HADOOP-7230.

        Show
        Aaron T. Myers added a comment - Rebase patch against trunk. Moves the tests for -help into common from HDFS per HADOOP-7230 .
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12477061/hdfs-1814.2.txt
        against trunk revision 1095830.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 17 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        -1 javac. The patch appears to cause tar ant target to fail.

        -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:

        -1 contrib tests. The patch failed contrib unit tests.

        -1 system test framework. The patch failed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/406//testReport/
        Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/406//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12477061/hdfs-1814.2.txt against trunk revision 1095830. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 17 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: -1 contrib tests. The patch failed contrib unit tests. -1 system test framework. The patch failed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/406//testReport/ Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/406//console This message is automatically generated.
        Hide
        Todd Lipcon added a comment -

        Rather than exposing the GroupMappingServiceProvider in HADOOP-7214, can you instead do something like:

        String[] groups = UserGroupInformation.createRemoteUser(username).getGroupNames()
        

        That seems preferable to keep the GMSP contained inside UGI/common.

        Show
        Todd Lipcon added a comment - Rather than exposing the GroupMappingServiceProvider in HADOOP-7214 , can you instead do something like: String [] groups = UserGroupInformation.createRemoteUser(username).getGroupNames() That seems preferable to keep the GMSP contained inside UGI/common.
        Hide
        Aaron T. Myers added a comment -

        Updated patch which uses the RefreshUserMappingsProtocol. This patch is dependent upon the latest patch posted to HADOOP-7214.

        Show
        Aaron T. Myers added a comment - Updated patch which uses the RefreshUserMappingsProtocol . This patch is dependent upon the latest patch posted to HADOOP-7214 .
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12478226/hdfs-1814.3.patch
        against trunk revision 1099525.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 5 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        -1 javac. The patch appears to cause tar ant target to fail.

        -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:

        -1 contrib tests. The patch failed contrib unit tests.

        -1 system test framework. The patch failed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/456//testReport/
        Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/456//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12478226/hdfs-1814.3.patch against trunk revision 1099525. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: -1 contrib tests. The patch failed contrib unit tests. -1 system test framework. The patch failed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/456//testReport/ Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/456//console This message is automatically generated.
        Hide
        Aaron T. Myers added a comment -

        Updated patch addressing Todd's comments.

        Show
        Aaron T. Myers added a comment - Updated patch addressing Todd's comments.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12478251/hdfs-1814.4.patch
        against trunk revision 1099641.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 5 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        -1 javac. The patch appears to cause tar ant target to fail.

        -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:

        -1 contrib tests. The patch failed contrib unit tests.

        -1 system test framework. The patch failed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/457//testReport/
        Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/457//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12478251/hdfs-1814.4.patch against trunk revision 1099641. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: -1 contrib tests. The patch failed contrib unit tests. -1 system test framework. The patch failed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/457//testReport/ Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/457//console This message is automatically generated.
        Hide
        Todd Lipcon added a comment -

        Looking pretty good. Any reason you chose to manually instantiate the NameNode rather than making a MiniHDFSCluster with no datanodes?

        I also noted that the ACLs are mostly listed in src/test/hadoop-policy.xml. Do you think we need to update that for any reason? (not sure I can figure out why it's in there)

        Show
        Todd Lipcon added a comment - Looking pretty good. Any reason you chose to manually instantiate the NameNode rather than making a MiniHDFSCluster with no datanodes? I also noted that the ACLs are mostly listed in src/test/hadoop-policy.xml. Do you think we need to update that for any reason? (not sure I can figure out why it's in there)
        Hide
        Aaron T. Myers added a comment -

        Looking pretty good. Any reason you chose to manually instantiate the NameNode rather than making a MiniHDFSCluster with no datanodes?

        No good reason. When I went looking for a test which tests an NN protocol, the first one that I found created a raw NameNode object, instead of creating a MiniDFSCluster. I can change this, if you'd like.

        I also noted that the ACLs are mostly listed in src/test/hadoop-policy.xml. Do you think we need to update that for any reason? (not sure I can figure out why it's in there)

        I'm afraid I don't know the answer to this one.

        Show
        Aaron T. Myers added a comment - Looking pretty good. Any reason you chose to manually instantiate the NameNode rather than making a MiniHDFSCluster with no datanodes? No good reason. When I went looking for a test which tests an NN protocol, the first one that I found created a raw NameNode object, instead of creating a MiniDFSCluster. I can change this, if you'd like. I also noted that the ACLs are mostly listed in src/test/hadoop-policy.xml. Do you think we need to update that for any reason? (not sure I can figure out why it's in there) I'm afraid I don't know the answer to this one.
        Hide
        Aaron T. Myers added a comment -

        Updated patch addressing review comments.

        I also noted that the ACLs are mostly listed in src/test/hadoop-policy.xml. Do you think we need to update that for any reason? (not sure I can figure out why it's in there)

        I did a little digging. I think this is only necessary if there are tests which exercise the authorization policy of this protocol. So, not necessary here.

        Show
        Aaron T. Myers added a comment - Updated patch addressing review comments. I also noted that the ACLs are mostly listed in src/test/hadoop-policy.xml. Do you think we need to update that for any reason? (not sure I can figure out why it's in there) I did a little digging. I think this is only necessary if there are tests which exercise the authorization policy of this protocol. So, not necessary here.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12478780/hdfs-1814.5.patch
        against trunk revision 1101753.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 5 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.cli.TestHDFSCLI
        org.apache.hadoop.hdfs.TestDFSShell
        org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
        org.apache.hadoop.hdfs.TestFileConcurrentReader
        org.apache.hadoop.tools.TestJMXGet

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/480//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/480//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/480//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12478780/hdfs-1814.5.patch against trunk revision 1101753. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.cli.TestHDFSCLI org.apache.hadoop.hdfs.TestDFSShell org.apache.hadoop.hdfs.TestDFSStorageStateRecovery org.apache.hadoop.hdfs.TestFileConcurrentReader org.apache.hadoop.tools.TestJMXGet +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/480//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/480//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/480//console This message is automatically generated.
        Hide
        Aaron T. Myers added a comment -

        The test failures are unrelated to this patch.

        Show
        Aaron T. Myers added a comment - The test failures are unrelated to this patch.
        Hide
        Todd Lipcon added a comment -

        Committed to trunk. Thanks, Aaron!

        Show
        Todd Lipcon added a comment - Committed to trunk. Thanks, Aaron!
        Hide
        Todd Lipcon added a comment -

        btw, should note that I manually tested this against a running NN before commit as well.

        Show
        Todd Lipcon added a comment - btw, should note that I manually tested this against a running NN before commit as well.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Is this an incompatible change?

        Show
        Tsz Wo Nicholas Sze added a comment - Is this an incompatible change?
        Hide
        Todd Lipcon added a comment -

        This just adds a new command - not sure why it would be considered incompatible?

        Show
        Todd Lipcon added a comment - This just adds a new command - not sure why it would be considered incompatible?
        Hide
        Aaron T. Myers added a comment -

        I would think this would be considered incompatible only if we consider the help output of `hdfs' and `mapred' to be interfaces whose backward compatibility we care about. I don't think we should.

        Show
        Aaron T. Myers added a comment - I would think this would be considered incompatible only if we consider the help output of `hdfs' and `mapred' to be interfaces whose backward compatibility we care about. I don't think we should.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Hey Todd, it is a question.

        The new protocol GetUserMappingsProtocol was added by HADOOP-7214. The old client won't use it. If the new client uses it to talk to an old server, it will get an exception. It seems no compatibility issue. Do you agree?

        Show
        Tsz Wo Nicholas Sze added a comment - Hey Todd, it is a question. The new protocol GetUserMappingsProtocol was added by HADOOP-7214 . The old client won't use it. If the new client uses it to talk to an old server, it will get an exception. It seems no compatibility issue. Do you agree?
        Hide
        Todd Lipcon added a comment -

        As far as I know we have not yet reached the point where protocol-level changes between releases are considered incompatible – i.e. no one expects an 0.22 client to talk to an 0.23 server or vice versa.

        Though I also agree that in this case, even if we had that guarantee, this wouldn't break anything since it is an additional protocol rather than a change to an old one.

        Show
        Todd Lipcon added a comment - As far as I know we have not yet reached the point where protocol-level changes between releases are considered incompatible – i.e. no one expects an 0.22 client to talk to an 0.23 server or vice versa. Though I also agree that in this case, even if we had that guarantee, this wouldn't break anything since it is an additional protocol rather than a change to an old one.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #658 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/658/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #658 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/658/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #673 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/673/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #673 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/673/ )

          People

          • Assignee:
            Aaron T. Myers
            Reporter:
            Aaron T. Myers
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development