[HDFS-16925] Namenode audit log to only include IP address of client

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.0, 3.3.6
• Fix Version/s: 3.4.0, 3.3.6
• Component/s: namanode
• Labels: pull-request-available
• Target Version/s: 3.4.0, 3.3.6
• Hadoop Flags: Reviewed
• Assignee: Viraj Jasani
• Reporter: Viraj Jasani
• Created: 15/Feb/23 20:22
• Updated: 28/Jan/24 07:16
• Resolved: 21/Feb/23 00:35

Description

Fixes broken test: TestAuditLogger by restoring the behaviour for audit logs prior to HADOOP-18628

With HADOOP-18628 in place, we perform InetAddress#getHostName in addition to InetAddress#getHostAddress, to save host name with IPC Connection object. When we perform InetAddress#getHostName, toString() of InetAddress would automatically print {hostName}/{hostIPAddress} if hostname is already resolved:

/**
 * Converts this IP address to a {@code String}. The
 * string returned is of the form: hostname / literal IP
 * address.
 *
 * If the host name is unresolved, no reverse name service lookup
 * is performed. The hostname part will be represented by an empty string.
 *
 * @return  a string representation of this IP address.
 */
public String toString() {
    String hostName = holder().getHostName();
    return ((hostName != null) ? hostName : "")
        + "/" + getHostAddress();
}

 

For namenode audit logs, this means that when dfs client makes filesystem updates, the audit logs would also print host name in the audit logs in addition to ip address.

In order to maintain the compatibility, the purpose of this Jira is to only let audit log retrieve IP address from InetAddress and print it.

Issue Links

• is broken by: HADOOP-18628 Server connection should log host name before returning VersionMismatch error
• links to: GitHub Pull Request #5407
• links to: GitHub Pull Request #5413