[HDFS-16753] WebHDFSHandler should reject non-compliant requests

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 3.4.0, 3.3.5
• Component/s: hdfs
• Labels: pull-request-available

Environment

Tested using both Maven Surefire and an IDE to demonstrate that the fix correctly rejects the invalid request with a 400 status code.

• Target Version/s: 3.3.9
• Assignee: Steve Vaughan
• Reporter: Steve Vaughan
• Created: 30/Aug/22 19:12
• Updated: 22/Feb/23 00:10

Description

When the nnId is not provided to the WebHDFSClient, the request uses null to generate a URI using a host name of "null" to construct a DFSClient instance.  In environments where the host name "null" doesn't resolve, the test passes due to the unresolvable name.  If the host name "null" does resolve, then this results in repeated attempts through the retry mechanism, eventually causing a timeout and a failed test result.

This change make the parameter a precondition for constructing the DFSClient, which throws an exception, rejecting the request, and return the expected 400 status code.

Issue Links

• links to: GitHub Pull Request #4834