Details

    • Hadoop Flags:
      Reviewed

      Description

      The value of dfs.heartbeat.interval is in seconds. Balancer seems misused it.

      1. h1665_20110225b.patch
        2 kB
        Tsz Wo Nicholas Sze
      2. h1665_20110225b_fed.patch
        1 kB
        Tsz Wo Nicholas Sze
      3. h1665_20110225.patch
        2 kB
        Tsz Wo Nicholas Sze

        Activity

        Hide
        szetszwo Tsz Wo Nicholas Sze added a comment -

        h1665_20110225.patch: changed 2 to 2000.

        Show
        szetszwo Tsz Wo Nicholas Sze added a comment - h1665_20110225.patch: changed 2 to 2000.
        Hide
        szetszwo Tsz Wo Nicholas Sze added a comment -

        h1665_20110225b.patch: removed an unnecessary synchronization.

        Show
        szetszwo Tsz Wo Nicholas Sze added a comment - h1665_20110225b.patch: removed an unnecessary synchronization.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12472015/h1665_20110225b.patch
        against trunk revision 1075571.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/222//testReport/
        Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/222//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/222//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12472015/h1665_20110225b.patch against trunk revision 1075571. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/222//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/222//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/222//console This message is automatically generated.
        Hide
        tlipcon Todd Lipcon added a comment -

        +1, good catch

        Show
        tlipcon Todd Lipcon added a comment - +1, good catch
        Hide
        szetszwo Tsz Wo Nicholas Sze added a comment -

        Thanks Todd for the review.

        Show
        szetszwo Tsz Wo Nicholas Sze added a comment - Thanks Todd for the review.
        Hide
        szetszwo Tsz Wo Nicholas Sze added a comment -

        h1665_20110225b_fed.patch: for federation

        Show
        szetszwo Tsz Wo Nicholas Sze added a comment - h1665_20110225b_fed.patch: for federation
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12472858/h1665_20110225b_fed.patch
        against trunk revision 1078925.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/235//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12472858/h1665_20110225b_fed.patch against trunk revision 1078925. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/235//console This message is automatically generated.
        Hide
        szetszwo Tsz Wo Nicholas Sze added a comment -

        I have committed this.

        Show
        szetszwo Tsz Wo Nicholas Sze added a comment - I have committed this.
        Hide
        szetszwo Tsz Wo Nicholas Sze added a comment -

        I forgot to say that I did not add new tests since the changes are obvious.

        Show
        szetszwo Tsz Wo Nicholas Sze added a comment - I forgot to say that I did not add new tests since the changes are obvious.
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #555 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/555/)

        Show
        hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #555 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/555/ )
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #643 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/643/)

        Show
        hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #643 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/643/ )
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Hdfs-22-branch #35 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-22-branch/35/)

        Show
        hudson Hudson added a comment - Integrated in Hadoop-Hdfs-22-branch #35 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-22-branch/35/ )

          People

          • Assignee:
            szetszwo Tsz Wo Nicholas Sze
            Reporter:
            szetszwo Tsz Wo Nicholas Sze
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development