[HDFS-16585] Add @VisibleForTesting in Dispatcher.java after HDFS-16268 - ASF JIRA

Voters

Watch issue

Watchers

Create sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Resolved
Priority: Trivial
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 3.4.0, 3.2.4, 3.3.5
Component/s: None
Labels:
- pull-request-available

Description

The scope of a few methods were opened up by ~~HDFS-16268~~ to facilitate unit testing. We should annotate them with @VisibleForTesting so that they don't get used by production code.

The affected methods include:
PendingMove
markMovedIfGoodBlock
isGoodBlockCandidate

Attachments

Issue Links

Add Link

links to

GitHub Pull Request #4337

Delete this link

Activity

Comment

This comment will be Viewable by All Users Viewable by All Users

Cancel

People

Assignee:: Ashutosh Gupta

Reporter:: Wei-Chiu Chuang

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 20/May/22 17:30

Updated:: 26/May/22 22:29

Resolved:: 26/May/22 22:29

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

Add @VisibleForTesting in Dispatcher.java after HDFS-16268