Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1625

TestDataNodeMXBean fails if disk space usage changes during test run

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: Federation Branch, 0.22.0, 0.23.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      I've seen this on our internal hudson - we get failures like:

      null expected:<...:{"freeSpace":857683[43552],"usedSpace":28672,"...> but was:<...:{"freeSpace":857683[59936],"usedSpace":28672,"...>

      because some other build on the same build slave used up some disk space during the middle of the test.

      1. h1625_20110228.patch
        1 kB
        Tsz Wo Nicholas Sze
      2. h1625_20110301.patch
        1 kB
        Tsz Wo Nicholas Sze

        Activity

        Todd Lipcon created issue -
        Hide
        Tsz Wo Nicholas Sze added a comment -

        h1625_20110228.patch: ignore numbers

        Show
        Tsz Wo Nicholas Sze added a comment - h1625_20110228.patch: ignore numbers
        Tsz Wo Nicholas Sze made changes -
        Field Original Value New Value
        Attachment h1625_20110228.patch [ 12472272 ]
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I also have encountered this problem. Here is a patch.

        h1625_20110228.patch: ignore numbers

        Show
        Tsz Wo Nicholas Sze added a comment - I also have encountered this problem. Here is a patch. h1625_20110228.patch: ignore numbers
        Tsz Wo Nicholas Sze made changes -
        Attachment h1625_20110228.patch [ 12472273 ]
        Tsz Wo Nicholas Sze made changes -
        Attachment h1625_20110228.patch [ 12472272 ]
        Hide
        Konstantin Boudnik added a comment -

        +1 patch looks good.
        A not: shall System.out.println be replace with a logger debug calls or removed all together?

        Show
        Konstantin Boudnik added a comment - +1 patch looks good. A not: shall System.out.println be replace with a logger debug calls or removed all together?
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Thanks Cos for the review.

        h1625_20110301.patch: removed println.

        Show
        Tsz Wo Nicholas Sze added a comment - Thanks Cos for the review. h1625_20110301.patch: removed println.
        Tsz Wo Nicholas Sze made changes -
        Attachment h1625_20110301.patch [ 12472336 ]
        Tsz Wo Nicholas Sze made changes -
        Assignee Todd Lipcon [ tlipcon ] Tsz Wo (Nicholas), SZE [ szetszwo ]
        Priority Major [ 3 ] Minor [ 4 ]
        Component/s test [ 12312916 ]
        Tsz Wo Nicholas Sze made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12472336/h1625_20110301.patch
        against trunk revision 1075571.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.hdfs.TestFileConcurrentReader

        -1 contrib tests. The patch failed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/221//testReport/
        Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/221//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/221//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12472336/h1625_20110301.patch against trunk revision 1075571. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.TestFileConcurrentReader -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/221//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/221//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/221//console This message is automatically generated.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have committed this.

        Show
        Tsz Wo Nicholas Sze added a comment - I have committed this.
        Tsz Wo Nicholas Sze made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Fix Version/s 0.22.0 [ 12314241 ]
        Fix Version/s 0.23.0 [ 12315571 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #549 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/549/)
        HDFS-1625. Ignore disk space values in TestDataNodeMXBean.

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #549 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/549/ ) HDFS-1625 . Ignore disk space values in TestDataNodeMXBean.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I forgot to say that the failed tests are obviously not related to this.

        Created HDFS-1679 for TestFileConcurrentReader.

        Show
        Tsz Wo Nicholas Sze added a comment - I forgot to say that the failed tests are obviously not related to this. Created HDFS-1679 for TestFileConcurrentReader.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Committed also to Federation Branch.

        Show
        Tsz Wo Nicholas Sze added a comment - Committed also to Federation Branch.
        Tsz Wo Nicholas Sze made changes -
        Fix Version/s Federation Branch [ 12315300 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #643 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/643/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #643 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/643/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-22-branch #35 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-22-branch/35/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-22-branch #35 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-22-branch/35/ )

          People

          • Assignee:
            Tsz Wo Nicholas Sze
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development