[HDFS-16231] Fix TestDataNodeMetrics#testReceivePacketSlowMetrics

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: datanode, metrics
• Labels: pull-request-available
• Target Version/s: 3.4.0
• Hadoop Flags: Reviewed
• Assignee: Haiyang Hu
• Reporter: Haiyang Hu
• Created: 19/Sep/21 05:28
• Updated: 12/Feb/24 06:18
• Resolved: 28/Sep/21 05:13

Description

TestDataNodeMetrics#testReceivePacketSlowMetrics fails with stacktrace:

java.lang.AssertionError: Expected exactly one metric for name TotalPacketsReceived 
Expected :1
Actual   :0
 <Click to see difference>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at org.apache.hadoop.test.MetricsAsserts.checkCaptured(MetricsAsserts.java:278)
	at org.apache.hadoop.test.MetricsAsserts.getLongCounter(MetricsAsserts.java:237)
	at org.apache.hadoop.hdfs.server.datanode.TestDataNodeMetrics.testReceivePacketSlowMetrics(TestDataNodeMetrics.java:200)

// Error MetricsName in current code，e.g TotalPacketsReceived，TotalPacketsSlowWriteToMirror，TotalPacketsSlowWriteToDisk，TotalPacketsSlowWriteToOsCache

      MetricsRecordBuilder dnMetrics = getMetrics(datanode.getMetrics().name());
      assertTrue("More than 1 packet received",
          getLongCounter("TotalPacketsReceived", dnMetrics) > 1L); 
      assertTrue("More than 1 slow packet to mirror",
          getLongCounter("TotalPacketsSlowWriteToMirror", dnMetrics) > 1L);
      assertCounter("TotalPacketsSlowWriteToDisk", 1L, dnMetrics);
      assertCounter("TotalPacketsSlowWriteToOsCache", 0L, dnMetrics);

Issue Links

• links to: GitHub Pull Request #3471