Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1618

configure files that are generated as part of the released tarball need to have executable bit set

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently the configure files that are packaged in a tarball are rw-rw-r-

      1. HDFS-1618.patch
        1.0 kB
        Roman Shaposhnik

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #643 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/643/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #643 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/643/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #541 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/541/)
        HDFS-1618. configure files that are generated as part of the released tarball need to have executable bit set. Contributed by Roman Shaposhnik

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #541 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/541/ ) HDFS-1618 . configure files that are generated as part of the released tarball need to have executable bit set. Contributed by Roman Shaposhnik
        Hide
        Konstantin Boudnik added a comment -

        I have just committed this to trunk and branch-0.22. Thanks Roman!

        Show
        Konstantin Boudnik added a comment - I have just committed this to trunk and branch-0.22. Thanks Roman!
        Hide
        Roman Shaposhnik added a comment -

        -1 core tests. The patch failed these core unit tests:

        org.apache.hadoop.hdfs.TestFileConcurrentReader

        Looks like it also fails on trunk. Not caused by the change

        -1 tests included. The patch doesn't appear to include any new or modified tests.

        This is a build change – hence no new tests

        Show
        Roman Shaposhnik added a comment - -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.TestFileConcurrentReader Looks like it also fails on trunk. Not caused by the change -1 tests included. The patch doesn't appear to include any new or modified tests. This is a build change – hence no new tests
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12470746/HDFS-1618.patch
        against trunk revision 1069561.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.hdfs.TestFileConcurrentReader

        -1 contrib tests. The patch failed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/159//testReport/
        Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/159//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/159//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12470746/HDFS-1618.patch against trunk revision 1069561. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.TestFileConcurrentReader -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/159//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/159//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/159//console This message is automatically generated.
        Hide
        Konstantin Boudnik added a comment -

        +1 patch looks good. Let's run it through usual validation cycle.

        Show
        Konstantin Boudnik added a comment - +1 patch looks good. Let's run it through usual validation cycle.
        Hide
        Roman Shaposhnik added a comment -

        Patch attached

        Show
        Roman Shaposhnik added a comment - Patch attached

          People

          • Assignee:
            Roman Shaposhnik
            Reporter:
            Roman Shaposhnik
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development