Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-16151

Improve the parameter comments related to ProtobufRpcEngine2#Server()

    XMLWordPrintableJSON

    Details

    • Hadoop Flags:
      Reviewed

      Description

      Now missing some parameter comments related to ProtobufRpcEngine2#Server(), as follows:
      /**

      • Construct an RPC server.
        *
      • @param protocolClass the class of protocol
      • @param protocolImpl the protocolImpl whose methods will be called
      • @param conf the configuration to use
      • @param bindAddress the address to bind on to listen for connection
      • @param port the port to listen for connections on
      • @param numHandlers the number of method handler threads to run
      • @param verbose whether each call should be logged
      • @param portRangeConfig A config parameter that can be used to restrict
      • the range of ports used when port is 0 (an ephemeral port)
      • @param alignmentContext provides server state info on client responses
        */
        public Server(Class<?> protocolClass, Object protocolImpl,
        Configuration conf, String bindAddress, int port, int numHandlers,
        int numReaders, int queueSizePerHandler, boolean verbose,
        SecretManager<? extends TokenIdentifier> secretManager,
        String portRangeConfig, AlignmentContext alignmentContext)
        throws IOException { super(protocolClass, protocolImpl, conf, bindAddress, port, numHandlers, numReaders, queueSizePerHandler, verbose, secretManager, portRangeConfig, alignmentContext); }

        The description of numReaders, queueSizePerHandler, and secretManager is missing here.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                jianghuazhu JiangHua Zhu
                Reporter:
                jianghuazhu JiangHua Zhu
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1.5h
                  1.5h