[HDFS-15877] BlockReconstructionWork should resetTargets() before BlockManager#validateReconstructionWork return false

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: block placement
• Labels: pull-request-available
• Target Version/s: 3.4.0
• Hadoop Flags: Reviewed
• Assignee: Haiyang Hu
• Reporter: Haiyang Hu
• Created: 05/Mar/21 11:52
• Updated: 11/Feb/24 09:01
• Resolved: 19/May/21 01:06

Description

BlockReconstructionWork should resetTargets() before BlockManager#validateReconstructionWork return false

the related code is in BlockManager.java

// code placeholder
private boolean validateReconstructionWork(BlockReconstructionWork rw) {
  BlockInfo block = rw.getBlock();
  int priority = rw.getPriority();
  ...
  if (block.isDeleted() || !block.isCompleteOrCommitted()) {
    neededReconstruction.remove(block, priority);
    rw.resetTargets();
    return false;
  }

  // do not schedule more if enough replicas is already pending
  ...
  if (hasEnoughEffectiveReplicas(block, numReplicas, pendingNum)) {
    neededReconstruction.remove(block, priority);
    rw.resetTargets();
    blockLog.debug("BLOCK* Removing {} from neededReconstruction as" +
        " it has enough replicas", block);
    return false;
  }

  DatanodeStorageInfo[] targets = rw.getTargets();
  BlockPlacementStatus placementStatus = getBlockPlacementStatus(block);
  if ((numReplicas.liveReplicas() >= requiredRedundancy) &&
      (!placementStatus.isPlacementPolicySatisfied())) {
    BlockPlacementStatus newPlacementStatus =
        getBlockPlacementStatus(block, targets);
    if (!newPlacementStatus.isPlacementPolicySatisfied() &&
        (newPlacementStatus.getAdditionalReplicasRequired() >=
            placementStatus.getAdditionalReplicasRequired())) {
      ...
      //Here to add rw.resetTargets();
      return false;
    }
  
    rw.setNotEnoughRack();
  }

  ...
  return true;
}

 

Issue Links

• links to: GitHub Pull Request #2747