[HDFS-15862] Make TestViewfsWithNfs3.testNfsRenameSingleNN() idempotent

• Type: Test
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.4.0, 3.3.2, 3.2.4
• Component/s: nfs
• Labels: pull-request-available
• Assignee: Zhengxi Li
• Reporter: Zhengxi Li
• Created: 26/Feb/21 06:48
• Updated: 04/Jan/22 22:45
• Resolved: 08/Dec/21 11:52

Description

The 'org.apache.hadoop.hdfs.nfs.nfs3.TestViewfsWithNfs3.testNfsRenameSingleNN' test is not idempotent and fails if run twice in the same JVM, because it pollutes state shared among tests. It may be good to clean this state pollution so that some other tests do not fail in the future due to the shared state polluted by this test.

Running TestViewfsWithNfs3.testNfsRenameSingleNN twice would result in the second run failing with a NullPointer exception:

[ERROR] Errors:
[ERROR]   TestViewfsWithNfs3.testNfsRenameSingleNN:317 NullPointer

The reason for this is that the /user1/renameSingleNN file is created in setup(), but gets renamed in testNfsRenameSingl{{eNN}}. When the second run of testNfsRenameSingleNN tries to get info of the file by its original name, it returns a NullPointer since the file no longer exists.

 

Link to PR: https://github.com/apache/hadoop/pull/2724

Issue Links

• links to: GitHub Pull Request #2724