Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: datanode
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      In supporting customers we often see things like SocketTimeoutExceptions or EOFExceptions coming from DataXceiver, but the logging isn't very good. For example, if we get an IOE while setting up a connection to the downstream mirror in writeBlock, the IP of the downstream mirror isn't logged on the DN side.

      1. HDFS-1568-6.patch
        5 kB
        Joey Echeverria
      2. HDFS-1568-5.patch
        5 kB
        Joey Echeverria
      3. HDFS-1568-4.patch
        4 kB
        Joey Echeverria
      4. HDFS-1568-3.patch
        4 kB
        Joey Echeverria
      5. HDFS-1568-output-changes.patch
        11 kB
        Joey Echeverria
      6. HDFS-1568-1.patch
        11 kB
        Joey Echeverria

        Activity

        Hide
        Joey Echeverria added a comment -

        Patch is ready for review. I added no tests since I was only changing logging code.

        Show
        Joey Echeverria added a comment - Patch is ready for review. I added no tests since I was only changing logging code.
        Hide
        Todd Lipcon added a comment -

        Hey Joey,

        It looks like a lot of the changes in this patch are just reformatting code without changing the underlying message. eg:

        • LOG.warn("Block token verification failed: op=" + op
        • + ", remoteAddress=" + remoteAddress
        • + ", message=" + e.getLocalizedMessage());
          + LOG.warn("Block token verification failed: op=" + op +
          + ", remoteAddress=" + remoteAddress +
          + ", message=" + e.getLocalizedMessage());

        would it be possible to format a patch which just contains changes which actually change output? That would be easier to review.

        Show
        Todd Lipcon added a comment - Hey Joey, It looks like a lot of the changes in this patch are just reformatting code without changing the underlying message. eg: LOG.warn("Block token verification failed: op=" + op + ", remoteAddress=" + remoteAddress + ", message=" + e.getLocalizedMessage()); + LOG.warn("Block token verification failed: op=" + op + + ", remoteAddress=" + remoteAddress + + ", message=" + e.getLocalizedMessage()); would it be possible to format a patch which just contains changes which actually change output? That would be easier to review.
        Hide
        Joey Echeverria added a comment -

        Sure, no problem.

        Show
        Joey Echeverria added a comment - Sure, no problem.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12479700/HDFS-1568-1.patch
        against trunk revision 1124459.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.hdfs.server.datanode.TestBlockReplacement
        org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
        org.apache.hadoop.hdfs.TestFileConcurrentReader
        org.apache.hadoop.tools.TestJMXGet

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/578//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/578//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/578//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12479700/HDFS-1568-1.patch against trunk revision 1124459. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.server.datanode.TestBlockReplacement org.apache.hadoop.hdfs.TestDFSStorageStateRecovery org.apache.hadoop.hdfs.TestFileConcurrentReader org.apache.hadoop.tools.TestJMXGet +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/578//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/578//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/578//console This message is automatically generated.
        Hide
        Joey Echeverria added a comment -

        Here's a new patch that only includes the changes that affect output in the logs. The rest of the changes in the original patch do one of two things:

        1) Re-format the code to be more consistent.
        2) Replace calls to s.getRemoteSocketAddress() in log statements with references to remoteAddress which is set in the constructor.

        Show
        Joey Echeverria added a comment - Here's a new patch that only includes the changes that affect output in the logs. The rest of the changes in the original patch do one of two things: 1) Re-format the code to be more consistent. 2) Replace calls to s.getRemoteSocketAddress() in log statements with references to remoteAddress which is set in the constructor.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12479798/HDFS-1568-output-changes.patch
        against trunk revision 1124576.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
        org.apache.hadoop.hdfs.TestFileConcurrentReader
        org.apache.hadoop.hdfs.TestHDFSTrash
        org.apache.hadoop.tools.TestJMXGet

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/586//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/586//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/586//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12479798/HDFS-1568-output-changes.patch against trunk revision 1124576. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.TestDFSStorageStateRecovery org.apache.hadoop.hdfs.TestFileConcurrentReader org.apache.hadoop.hdfs.TestHDFSTrash org.apache.hadoop.tools.TestJMXGet +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/586//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/586//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/586//console This message is automatically generated.
        Hide
        Tsz Wo Nicholas Sze added a comment -
        • Could you not reformat the message in this? Otherwise, it is hard to review the patch. You may fix the message format in a separated JIRA.
          -          block + " to " +
          -                s.getInetAddress() + ":\n" + 
          -                StringUtils.stringifyException(ioe) );
          +               block + " to " +
          +               remoteAddress + ":\n" + 
          +               StringUtils.stringifyException(ioe) );
          
        Show
        Tsz Wo Nicholas Sze added a comment - Could you not reformat the message in this? Otherwise, it is hard to review the patch. You may fix the message format in a separated JIRA. - block + " to " + - s.getInetAddress() + ":\n" + - StringUtils.stringifyException(ioe) ); + block + " to " + + remoteAddress + ":\n" + + StringUtils.stringifyException(ioe) );
        Hide
        Joey Echeverria added a comment -

        Is this last patch better?

        Show
        Joey Echeverria added a comment - Is this last patch better?
        Hide
        Joey Echeverria added a comment -

        Canceling previous patch.

        Show
        Joey Echeverria added a comment - Canceling previous patch.
        Hide
        Joey Echeverria added a comment -

        Submitting the third patch.

        Show
        Joey Echeverria added a comment - Submitting the third patch.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Thanks Joey.

        • It is better to log before ERROR.write(out), otherwise, ERROR.write(out) may throw another exception.
                 } catch(IOException e) {
                   ERROR.write(out);
          +        LOG.info("opReadBlock " + block + " received exception " + e);
                   throw e;
                 }
          
        • Since the exception e is re-thrown, are you sure that it won't be printed twice?
                     if (isClient) {
          +            LOG.error(datanode + ":Exception transfering block " +
          +                     block + " to mirror " + mirrorNode +
          +                     ".", e);
                       throw e;
          
        Show
        Tsz Wo Nicholas Sze added a comment - Thanks Joey. It is better to log before ERROR.write(out) , otherwise, ERROR.write(out) may throw another exception. } catch (IOException e) { ERROR.write(out); + LOG.info( "opReadBlock " + block + " received exception " + e); throw e; } Since the exception e is re-thrown, are you sure that it won't be printed twice? if (isClient) { + LOG.error(datanode + ":Exception transfering block " + + block + " to mirror " + mirrorNode + + "." , e); throw e;
        Hide
        Joey Echeverria added a comment -

        > It is better to log before ERROR.write(out), otherwise, ERROR.write(out) may throw another exception.
        Good catch, I'll fix that.

        > Since the exception e is re-thrown, are you sure that it won't be printed twice?
        You're correct. Should I just include e.toString() or e.getMessage() there?

        I think there are a couple of other places where the exception might get printed more than once. Should those be fixed as part of this jira, or filed separately?

        Finally, do you know why some stack traces are printed out by using stringifyException() and others are printed by just passing the exception to the LOG.error() function?

        Show
        Joey Echeverria added a comment - > It is better to log before ERROR.write(out), otherwise, ERROR.write(out) may throw another exception. Good catch, I'll fix that. > Since the exception e is re-thrown, are you sure that it won't be printed twice? You're correct. Should I just include e.toString() or e.getMessage() there? I think there are a couple of other places where the exception might get printed more than once. Should those be fixed as part of this jira, or filed separately? Finally, do you know why some stack traces are printed out by using stringifyException() and others are printed by just passing the exception to the LOG.error() function?
        Hide
        Tsz Wo Nicholas Sze added a comment -

        > You're correct. Should I just include e.toString() or e.getMessage() there?

        Probably e.getMessage(). Please run some tests to see how it looks after the patch.

        > I think there are a couple of other places where the exception might get printed more than once. Should those be fixed as part of this jira, or filed separately?

        It would be great if you can fix it separately.

        > Finally, do you know why some stack traces are printed out by using stringifyException() and others are printed by just passing the exception to the LOG.error() function?

        If I remember correctly, the previous log API did not have methods for printing exceptions, i.e. the only have log.info(message) but not log.info(message, exception). So we have to use stringifyException(). From now on, we should not use stringifyException().

        Show
        Tsz Wo Nicholas Sze added a comment - > You're correct. Should I just include e.toString() or e.getMessage() there? Probably e.getMessage() . Please run some tests to see how it looks after the patch. > I think there are a couple of other places where the exception might get printed more than once. Should those be fixed as part of this jira, or filed separately? It would be great if you can fix it separately. > Finally, do you know why some stack traces are printed out by using stringifyException() and others are printed by just passing the exception to the LOG.error() function? If I remember correctly, the previous log API did not have methods for printing exceptions, i.e. the only have log.info(message) but not log.info(message, exception) . So we have to use stringifyException() . From now on, we should not use stringifyException() .
        Hide
        Joey Echeverria added a comment -

        Thanks for the feedback. I'll file new jiras for the extra exceptions being printed in the use of stringifyException().

        Show
        Joey Echeverria added a comment - Thanks for the feedback. I'll file new jiras for the extra exceptions being printed in the use of stringifyException().
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12479932/HDFS-1568-3.patch
        against trunk revision 1125217.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
        org.apache.hadoop.hdfs.TestFileConcurrentReader
        org.apache.hadoop.hdfs.TestHDFSTrash

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/603//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/603//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/603//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12479932/HDFS-1568-3.patch against trunk revision 1125217. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.TestDFSStorageStateRecovery org.apache.hadoop.hdfs.TestFileConcurrentReader org.apache.hadoop.hdfs.TestHDFSTrash +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/603//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/603//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/603//console This message is automatically generated.
        Hide
        Joey Echeverria added a comment -

        I took a look at some more of the logging output. The only problem I see with e.getMessage() is some common exceptions to provide a message at all. For example, EOFExceptions seem to rarely have a message. If you do e.toString(), you'll see both the name of the class and the message (if one was provided). Let me know how you think I should proceed and I'll submit a new patch.

        Show
        Joey Echeverria added a comment - I took a look at some more of the logging output. The only problem I see with e.getMessage() is some common exceptions to provide a message at all. For example, EOFExceptions seem to rarely have a message. If you do e.toString(), you'll see both the name of the class and the message (if one was provided). Let me know how you think I should proceed and I'll submit a new patch.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Then, e.toString() is fine.

        Show
        Tsz Wo Nicholas Sze added a comment - Then, e.toString() is fine.
        Hide
        Joey Echeverria added a comment -

        I incorporated the most recent feedback and rebased the patch on the latest trunk.

        Show
        Joey Echeverria added a comment - I incorporated the most recent feedback and rebased the patch on the latest trunk.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12480359/HDFS-1568-4.patch
        against trunk revision 1127317.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.hdfs.server.namenode.TestOverReplicatedBlocks
        org.apache.hadoop.hdfs.TestDFSStorageStateRecovery

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/621//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/621//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/621//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12480359/HDFS-1568-4.patch against trunk revision 1127317. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.server.namenode.TestOverReplicatedBlocks org.apache.hadoop.hdfs.TestDFSStorageStateRecovery +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/621//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/621//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/621//console This message is automatically generated.
        Hide
        Joey Echeverria added a comment -

        Canceling patch to upload one rebased to trunk.

        Show
        Joey Echeverria added a comment - Canceling patch to upload one rebased to trunk.
        Hide
        Joey Echeverria added a comment -

        Rebased patch to trunk.

        Show
        Joey Echeverria added a comment - Rebased patch to trunk.
        Hide
        Joey Echeverria added a comment -

        Oops, jumped the gun on that last upload. This patch should be good.

        Show
        Joey Echeverria added a comment - Oops, jumped the gun on that last upload. This patch should be good.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12483041/HDFS-1568-6.patch
        against trunk revision 1136975.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:

        -1 contrib tests. The patch failed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/796//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/796//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/796//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12483041/HDFS-1568-6.patch against trunk revision 1136975. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/796//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/796//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/796//console This message is automatically generated.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        The previous build failed unexpectedly. I have restarted a new build.

        Show
        Tsz Wo Nicholas Sze added a comment - The previous build failed unexpectedly. I have restarted a new build.
        Hide
        Joey Echeverria added a comment -

        Thanks.

        Show
        Joey Echeverria added a comment - Thanks.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12483041/HDFS-1568-6.patch
        against trunk revision 1137675.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/803//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/803//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/803//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12483041/HDFS-1568-6.patch against trunk revision 1137675. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/803//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/803//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/803//console This message is automatically generated.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1 patch looks good.

        Show
        Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have committed this. Thanks, Joey!

        Show
        Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Joey!
        Hide
        Joey Echeverria added a comment -

        Thanks Tsz-Wo

        Show
        Joey Echeverria added a comment - Thanks Tsz-Wo
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #752 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/752/)
        HDFS-1568. Improve the log messages in DataXceiver. Contributed by Joey Echeverria

        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1138098
        Files :

        • /hadoop/common/trunk/hdfs/CHANGES.txt
        • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #752 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/752/ ) HDFS-1568 . Improve the log messages in DataXceiver. Contributed by Joey Echeverria szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1138098 Files : /hadoop/common/trunk/hdfs/CHANGES.txt /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #703 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/703/)
        HDFS-1568. Improve the log messages in DataXceiver. Contributed by Joey Echeverria

        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1138098
        Files :

        • /hadoop/common/trunk/hdfs/CHANGES.txt
        • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #703 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/703/ ) HDFS-1568 . Improve the log messages in DataXceiver. Contributed by Joey Echeverria szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1138098 Files : /hadoop/common/trunk/hdfs/CHANGES.txt /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java

          People

          • Assignee:
            Joey Echeverria
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development