[HDFS-15579] RBF: The constructor of PathLocation may got some misunderstanding

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.4.0
• Component/s: rbf
• Hadoop Flags: Reviewed
• Assignee: Janus Chow
• Reporter: Janus Chow
• Created: 15/Sep/20 10:41
• Updated: 20/Sep/20 03:28
• Resolved: 20/Sep/20 03:28

Description

There is a constructor of PathLocation as follows, it's for creating a new PathLocation with a prioritised nsId. 

 

public PathLocation(PathLocation other, String firstNsId) {
  this.sourcePath = other.sourcePath;
  this.destOrder = other.destOrder;
  this.destinations = orderedNamespaces(other.destinations, firstNsId);
}

When I was reading the code of MultipleDestinationMountTableResolver, I thought this constructor was to create a PathLocation with an override destination. It took me a while before I realize this is a constructor to sort the destinations inside.

Maybe I think this constructor can be more clear about its usage?