Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change
    • Release Note:
      On web UI, missing block number now becomes accurate and under-replicated blocks do not include missing blocks.

      Description

      1. Make the missing blocks count accurate;
      2. Make the under replicated blocks count excluding missing blocks.

      1. missingBlocksWebUI1.patch
        8 kB
        Hairong Kuang
      2. missingBlocksWebUI.patch
        7 kB
        Hairong Kuang

        Activity

        Hide
        Hairong Kuang added a comment -

        The patch adds a separate queue in neededReplication for replicas that has only zero replica. The missing block count is set to be the size of this queue, while the under-replication blocks count is equal to the number of the rest of under-replicated blocks.

        Show
        Hairong Kuang added a comment - The patch adds a separate queue in neededReplication for replicas that has only zero replica. The missing block count is set to be the size of this queue, while the under-replication blocks count is equal to the number of the rest of under-replicated blocks.
        Hide
        Nigel Daley added a comment -

        Hairong, can you add a tooltip that describes the new meaning of this value in context? Something like:

        private String colTxt(String title) {
          return "<td id=\"col" + ++colNum + "\" title=\"" + title + "\"> ";
        }
        ...
        colTxt("Excludes missing blocks.")
        

        We should probably do this for other fields too, but that's a separate jira.

        Show
        Nigel Daley added a comment - Hairong, can you add a tooltip that describes the new meaning of this value in context? Something like: private String colTxt( String title) { return "<td id=\" col " + ++colNum + " \ " title=\" " + title + " \ "> " ; } ... colTxt( "Excludes missing blocks." ) We should probably do this for other fields too, but that's a separate jira.
        Hide
        Hairong Kuang added a comment -

        MissingBlocksWebUI1.patch addressed Nigel's comments.

        Show
        Hairong Kuang added a comment - MissingBlocksWebUI1.patch addressed Nigel's comments.
        Hide
        dhruba borthakur added a comment -

        +1

        Show
        dhruba borthakur added a comment - +1
        Hide
        Hairong Kuang added a comment -

        [exec] +1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] +1 tests included. The patch appears to include 3 new or modified tests.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total number of release au
        [exec] dit warnings.
        [exec]
        [exec] +1 system test framework. The patch passed system test framework compile.

        Failed unit tests are TestHDFSServrPorts, TestHDFSTrash, TestBackupNode, TestStorageRestore, and TestDFSRollback.

        Show
        Hairong Kuang added a comment - [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release au [exec] dit warnings. [exec] [exec] +1 system test framework. The patch passed system test framework compile. Failed unit tests are TestHDFSServrPorts, TestHDFSTrash, TestBackupNode, TestStorageRestore, and TestDFSRollback.
        Hide
        Hairong Kuang added a comment -

        I've just committed this. Thank Dhruba and Nigel for reviewing this!

        Show
        Hairong Kuang added a comment - I've just committed this. Thank Dhruba and Nigel for reviewing this!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #643 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/643/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #643 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/643/ )

          People

          • Assignee:
            Hairong Kuang
            Reporter:
            Hairong Kuang
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development