[HDFS-15123] Remove unnecessary null check in FoldedTreeSet

• Type: Bug
• Status: Patch Available
• Priority: Minor
• Resolution: Unresolved
• Fix Version/s: 3.1.1
• Assignee: Ravuri Sushma sree
• Reporter: Ravuri Sushma sree
• Created: 14/Jan/20 17:43
• Updated: 28/Jul/20 22:52

Description

if (toMoveUp.left != null) and if (toMoveUp.right != null) null checks are not necessary as they are being handled in the if and else if conditions

private void deleteNode(final Node<E> node) {
 if (node.right == null) {
 if (node.left != null)
{ attachToParent(node, node.left); }
else
{ attachNullToParent(node); }
} else if (node.left == null) {
 attachToParent(node, node.right);
 } else {
 else {
 // node.left != null && node.right != null
 // node.next should replace node in tree
 // node.next != null guaranteed since node.left != null
 // node.next.left == null since node.next.prev is node
 // node.next.right may be null or non-null
 Node<E> toMoveUp = node.next;
 if (toMoveUp.right == null)
{ attachNullToParent(toMoveUp); }
else
{ attachToParent(toMoveUp, toMoveUp.right); }
toMoveUp.left = node.left;
  if (toMoveUp.left != null) {
  toMoveUp.left.parent = toMoveUp;
 }
 toMoveUp.right = node.right;
 if (toMoveUp.right != null) {
  toMoveUp.right.parent = toMoveUp;
  }
 attachToParentNoBalance(node, toMoveUp);
 toMoveUp.color = node.color;
 }