[HDFS-1502] TestBlockRecovery triggers NPE in assert

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.22.0
• Fix Version/s: 0.22.0, 0.23.0
• Hadoop Flags: Reviewed
• Assignee: Hairong Kuang
• Reporter: Eli Collins
• Created: 17/Nov/10 19:35
• Updated: 21/Apr/11 23:32
• Resolved: 06/Dec/10 04:36

Description

Testcase: testRBW_RWRReplicas took 10.333 sec
        Caused an ERROR
null
java.lang.NullPointerException
        at org.apache.hadoop.hdfs.server.datanode.DataNode.syncBlock(DataNode.java:1881)
        at org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery.testSyncReplicas(TestBlockRecovery.java:144)
        at org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery.testRBW_RWRReplicas(TestBlockRecovery.java:305)

        Block reply = r.datanode.updateReplicaUnderRecovery(
            r.rInfo, recoveryId, newBlock.getNumBytes());
        assert reply.equals(newBlock) &&
               reply.getNumBytes() == newBlock.getNumBytes() :
          "Updated replica must be the same as the new block.";    <----- line 1881

Not sure how reply could be null since updateReplicaUnderRecovery always returns a newly instantiated object.