[HDFS-14999] Avoid Potential Infinite Loop in DFSNetworkTopology

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.3.1, 3.4.0
• Fix Version/s: 3.3.1, 3.4.0
• Component/s: dfs
• Target Version/s: 3.3.1, 3.4.0
• Hadoop Flags: Reviewed
• Assignee: Ayush Saxena
• Reporter: Ayush Saxena
• Created: 20/Nov/19 21:38
• Updated: 11/Feb/24 06:24
• Resolved: 18/May/20 17:02

Description

    do {
      chosen = chooseRandomWithStorageTypeAndExcludeRoot(root, excludeRoot,
          type);
      if (excludedNodes == null || !excludedNodes.contains(chosen)) {
        break;
      } else {
        LOG.debug("Node {} is excluded, continuing.", chosen);
      }
    } while (true);

Observed this loop getting stuck as part of testing HDFS-14913.

There should be some exit condition or max retries here

Issue Links

• relates to: HADOOP-15317 Improve NetworkTopology chooseRandom's loop