[HDFS-14721] RBF: ProxyOpComplete is not accurate in FederationRPCPerformanceMonitor

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.3.0
• Component/s: rbf
• Hadoop Flags: Reviewed
• Assignee: ZanderXu
• Reporter: ZanderXu
• Created: 12/Aug/19 09:24
• Updated: 29/Aug/19 14:50
• Resolved: 29/Aug/19 14:50

Description

ProxyOpComplete is not accurate in FederationRPCPerformanceMonitor when RemoteException is returned.

Because the remoteException is unwrap in invoke method, and it will be proxyOpComplete(false) in invokeMethod.

// invoke method
if (ioe instanceof RemoteException) {
  RemoteException re = (RemoteException) ioe;
  ioe = re.unwrapRemoteException();
  ioe = getCleanException(ioe);
}

// invokeMethod method
if (this.rpcMonitor != null) {
  this.rpcMonitor.proxyOpFailureCommunicate();
  this.rpcMonitor.proxyOpComplete(false);
}
throw ioe;