Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-14721

RBF: ProxyOpComplete is not accurate in FederationRPCPerformanceMonitor

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 3.3.0
    • rbf
    • None
    • Reviewed

    Description

      ProxyOpComplete is not accurate in FederationRPCPerformanceMonitor when RemoteException is returned.

      Because the remoteException is unwrap in invoke method, and it will be proxyOpComplete(false) in invokeMethod.

      // invoke method
      if (ioe instanceof RemoteException) {
        RemoteException re = (RemoteException) ioe;
        ioe = re.unwrapRemoteException();
        ioe = getCleanException(ioe);
      }
      
      // invokeMethod method
      if (this.rpcMonitor != null) {
        this.rpcMonitor.proxyOpFailureCommunicate();
        this.rpcMonitor.proxyOpComplete(false);
      }
      throw ioe;

      Attachments

        1. HDFS-14721-trunk-004.patch
          4 kB
          ZanderXu
        2. HDFS-14721-trunk-003.patch
          4 kB
          ZanderXu
        3. HDFS-14721-trunk-002.patch
          5 kB
          ZanderXu
        4. HDFS-14721-trunk-001.patch
          5 kB
          ZanderXu

        Activity

          People

            xuzq_zander ZanderXu
            xuzq_zander ZanderXu
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: