[HDFS-14203] Refactor OIV Delimited output entry building mechanism

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.2.0
• Fix Version/s: 3.3.0
• Component/s: tools
• Assignee: Adam Antal
• Reporter: Adam Antal
• Created: 14/Jan/19 11:38
• Updated: 02/Oct/19 17:14
• Resolved: 15/Jun/19 13:49

Description

As of some recent improvements in the OIV tool, fields are getting added. For sustainability I propose to introduce a Builder pattern in PBImageDelimitedTextWriter, which is also prettier than constructing entries like this:

    case SYMLINK:
      INodeSymlink s = inode.getSymlink();
      p = getPermission(s.getPermission());
      append(buffer, 0);  // Replication
      append(buffer, formatDate(s.getModificationTime()));
      append(buffer, formatDate(s.getAccessTime()));
      append(buffer, 0);  // Block size.
      append(buffer, 0);  // Num blocks.
      append(buffer, 0);  // Num bytes.
      append(buffer, 0);  // NS_QUOTA
      append(buffer, 0);  // DS_QUOTA