Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-14203

Refactor OIV Delimited output entry building mechanism

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2.0
    • Fix Version/s: 3.3.0
    • Component/s: tools
    • Labels:
      None

      Description

      As of some recent improvements in the OIV tool, fields are getting added. For sustainability I propose to introduce a Builder pattern in PBImageDelimitedTextWriter, which is also prettier than constructing entries like this:

          case SYMLINK:
            INodeSymlink s = inode.getSymlink();
            p = getPermission(s.getPermission());
            append(buffer, 0);  // Replication
            append(buffer, formatDate(s.getModificationTime()));
            append(buffer, formatDate(s.getAccessTime()));
            append(buffer, 0);  // Block size.
            append(buffer, 0);  // Num blocks.
            append(buffer, 0);  // Num bytes.
            append(buffer, 0);  // NS_QUOTA
            append(buffer, 0);  // DS_QUOTA
      

        Attachments

        1. HDFS-14203.003.patch
          15 kB
          Adam Antal
        2. HDFS-14203.002.patch
          14 kB
          Adam Antal
        3. HDFS-14203.001.patch
          14 kB
          Adam Antal

          Activity

            People

            • Assignee:
              adam.antal Adam Antal
              Reporter:
              adam.antal Adam Antal
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: