[HDFS-14119] Improve GreedyPlanner Parameter Logging

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 3.3.0
• Fix Version/s: 3.3.0
• Component/s: hdfs
• Assignee: David Mollitor
• Reporter: David Mollitor
• Created: 30/Nov/18 23:01
• Updated: 03/Dec/18 21:15
• Resolved: 03/Dec/18 20:56

Description

1. Do not use String.format() in conjunction with SLF4J. Superfluous.

String message = String
.format("Compute Plan for Node : %s:%d took %d ms ",
node.getDataNodeName(), node.getDataNodePort(),
endTime - startTime);
LOG.info(message);

2. Do not call an explicit toString() on an object with SLF4J parameter. Otherwise, the string will be created and then thrown away if the logger is not set to debug level. Just pass the object itself and the framework will call toString if needed.

LOG.debug("Step : {} ",  nextStep.toString());