Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-14056

Fix error messages in HDFS-12716

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.10.0, 3.2.0, 3.0.4, 3.1.2
    • Fix Version/s: 2.10.0, 3.0.4, 3.1.2, 3.3.0, 3.2.1
    • Component/s: hdfs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      There are misleading error messages in the committed HDFS-12716 patch.

      As I saw in the code in DataNode.java:startDataNode

          throw new DiskErrorException("Invalid value configured for "
              + "dfs.datanode.failed.volumes.tolerated - " + volFailuresTolerated
              + ". Value configured is either greater than -1 or >= "
              + "to the number of configured volumes (" + volsConfigured + ").");
        }
      

      Here the error message seems a bit misleading. The error comes up when the given quantity in the configuration set to volsConfigured is set lower than -1 but in that case the error should say something like "Value configured is either less than -1 or >= ...".

      Also the general error message in DataNode.java

      public static final String MAX_VOLUME_FAILURES_TOLERATED_MSG = "should be greater than -1";
      

      May be better changed to "should be greater than or equal to -1" to be precise, as -1 is a valid choice.

      In hdfs-default.xml I couldn't understand the phrase "The range of the value is -1 now, -1 represents the minimum of volume valids is 1." It might be better to write something clearer like "The minimum is -1 representing 1 valid remaining volume".

        Attachments

        1. HDFS-14056-02.patch
          2 kB
          Ayush Saxena
        2. HDFS-14056-01.patch
          2 kB
          Ayush Saxena

          Activity

            People

            • Assignee:
              ayushtkn Ayush Saxena
              Reporter:
              adam.antal Adam Antal
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: