Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1395

Add @Override annotation to FSDataset methods that implement FSDatasetInterface

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: datanode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      @Override annotations are inconsistently added to methods implementing the interface.

      1. HDFS-1395.patch
        6 kB
        Suresh Srinivas

        Activity

        Hide
        Suresh Srinivas added a comment -

        Patch with @Override annotations added

        Show
        Suresh Srinivas added a comment - Patch with @Override annotations added
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1 patch looks good.

        Show
        Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
        Hide
        Suresh Srinivas added a comment -

        Since Hudson is down I ran testpatch with the following results:
        [exec] -1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
        [exec] Please justify why no new tests are needed for this patch.
        [exec] Also please list what manual steps were performed to verify this patch.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
        [exec]
        [exec] +1 system tests framework. The patch passed system tests framework compile.

        Tests are not included since this is just an annotation change.

        Show
        Suresh Srinivas added a comment - Since Hudson is down I ran testpatch with the following results: [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system tests framework. The patch passed system tests framework compile. Tests are not included since this is just an annotation change.
        Hide
        Suresh Srinivas added a comment -

        I committed the patch to trunk.

        Show
        Suresh Srinivas added a comment - I committed the patch to trunk.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #386 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/386/)
        HDFS-1395. Add @Override to FSDataset methods that implement FSDatasetInterface methods. Contributed by Suresh Srinivas.

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #386 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/386/ ) HDFS-1395 . Add @Override to FSDataset methods that implement FSDatasetInterface methods. Contributed by Suresh Srinivas.

          People

          • Assignee:
            Suresh Srinivas
            Reporter:
            Suresh Srinivas
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development