Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-13701

Removal of logging guards regressed performance

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Major
    • Resolution: Unresolved
    • 3.0.0
    • None
    • performance
    • None

    Description

      HDFS-8971 removed various logging guards from hot methods in the DFS client. In theory using a format string with {} placeholders is equivalent, but in fact it's not equivalent when one or more of the variable arguments are primitives. To be passed as part of the varargs array, the primitives need to be boxed. I am seeing Integer.valueOf() inside BlockReaderLocal.read taking ~3% of CPU.

      Attachments

        Activity

          People

            Unassigned Unassigned
            tlipcon Todd Lipcon
            Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

            Dates

              Created:
              Updated: