[HDFS-13637] RBF: Router fails when threadIndex (in ConnectionPool) wraps around Integer.MIN_VALUE

• Type: Sub-task
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 2.10.0, 3.2.0, 3.1.1, 2.9.2, 3.0.4
• Component/s: federation
• Labels: RBF
• Hadoop Flags: Reviewed
• Assignee: CR Hota
• Reporter: CR Hota
• Created: 30/May/18 00:17
• Updated: 06/Jul/18 22:13
• Resolved: 02/Jun/18 00:04

Description

    int threadIndex = this.clientIndex.getAndIncrement();
    for (int i=0; i<size; i++) {
      int index = (threadIndex + i) % size;
      conn = tmpConnections.get(index);
      if (conn != null && conn.isUsable()) {
        return conn;
      }
    }

The above code in ConnectionPool.java getConnection method throws java.lang.ArrayIndexOutOfBoundsException when clientIndex wraps to Integer.MIN_VALUE and makes router reject all requests. threadIndex should be reset to 0.

    if (threadIndex < 0) {
        // Wrap around 0 to keep array lookup index positive
        this.clientIndex.set(0);
        threadIndex = this.clientIndex.getAndIncrement();
    }