[HDFS-13480] RBF: Separate namenodeHeartbeat and routerHeartbeat to different config key

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.3.0, HDFS-13891
• Hadoop Flags: Reviewed
• Assignee: Ayush Saxena
• Reporter: Baolong Mao
• Created: 19/Apr/18 06:12
• Updated: 12/Sep/19 20:05
• Resolved: 01/Jun/19 04:42

Description

Now, if i enable the heartbeat.enable, but i do not want to monitor any namenode, i get an ERROR log like:

[2018-04-19T14:00:03.057+08:00] [ERROR] federation.router.Router.serviceInit(Router.java 214) [main] : Heartbeat is enabled but there are no namenodes to monitor

and if i disable the heartbeat.enable, we cannot get any mounttable update, because the following logic in Router.java：

if (conf.getBoolean(
        RBFConfigKeys.DFS_ROUTER_HEARTBEAT_ENABLE,
        RBFConfigKeys.DFS_ROUTER_HEARTBEAT_ENABLE_DEFAULT)) {

      // Create status updater for each monitored Namenode
      this.namenodeHeartbeatServices = createNamenodeHeartbeatServices();
      for (NamenodeHeartbeatService hearbeatService :
          this.namenodeHeartbeatServices) {
        addService(hearbeatService);
      }

      if (this.namenodeHeartbeatServices.isEmpty()) {
        LOG.error("Heartbeat is enabled but there are no namenodes to monitor");
      }

      // Periodically update the router state
      this.routerHeartbeatService = new RouterHeartbeatService(this);
      addService(this.routerHeartbeatService);
    }