Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-12615 Router-based HDFS federation phase 2
  3. HDFS-13435

RBF: Improve the error loggings for printing the stack trace

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 3.0.1
    • 2.10.0, 3.2.0, 3.1.1, 2.9.2, 3.0.3
    • None
    • None
    • Reviewed

    Description

      There are many places that using Logger.error(String format, Object... arguments) incorrectly.
      A example:

      LOG.error("Cannot remove {}", path, e);
      

      The exception passed here is no meaning and won't be printed. Actually it should be update to

      LOG.error("Cannot remove {}: {}.", path, e.getMessage());
      

      or

      LOG.error("Cannot remove " +  path, e));
      

      Attachments

        1. HDFS-13435.001.patch
          17 kB
          Yiqun Lin
        2. HDFS-13435.002.patch
          10 kB
          Yiqun Lin
        3. HDFS-13435.003.patch
          7 kB
          Yiqun Lin

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            linyiqun Yiqun Lin
            linyiqun Yiqun Lin
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment