[HDFS-13435] RBF: Improve the error loggings for printing the stack trace

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.1
• Fix Version/s: 2.10.0, 3.2.0, 3.1.1, 2.9.2, 3.0.3
• Target Version/s: 3.2.0, 3.1.1
• Hadoop Flags: Reviewed
• Assignee: Yiqun Lin
• Reporter: Yiqun Lin
• Created: 12/Apr/18 06:11
• Updated: 08/May/18 18:36
• Resolved: 17/Apr/18 03:35

Description

There are many places that using Logger.error(String format, Object... arguments) incorrectly.
A example:

LOG.error("Cannot remove {}", path, e);

The exception passed here is no meaning and won't be printed. Actually it should be update to

LOG.error("Cannot remove {}: {}.", path, e.getMessage());

or

LOG.error("Cannot remove " +  path, e));