Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-13418

NetworkTopology should be configurable when enable DFSNetworkTopology

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.1
    • Fix Version/s: 2.10.0, 3.2.0, 3.1.1
    • Component/s: None
    • Labels:
      None

      Description

      In HDFS-11530 we introduce DFSNetworkTopology and in HDFS-11998 we set DFSNetworkTopology as the default implementation.

      We still have net.topology.impl=org.apache.hadoop.net.NetworkTopology in core-site.default. Actually this property does not effect once dfs.use.dfs.network.topology is true.
      in DatanodeManager,networkTopology is initialized as

          if (useDfsNetworkTopology) {
            networktopology = DFSNetworkTopology.getInstance(conf);
          } else {
            networktopology = NetworkTopology.getInstance(conf);
          }
      

      I think we should still make the NetworkTopology configurable rather than hard code the implementation since we may need another NetworkTopology impl.
      I am not sure if there is other consideration. Any thought? Chen Liang Yiqun Lin

        Attachments

        1. HDFS-13418-branch2.001.patch
          8 kB
          Tao Jie
        2. HDFS-13418.004.patch
          8 kB
          Tao Jie
        3. HDFS-13418.003.patch
          8 kB
          Tao Jie
        4. HDFS-13418.002.patch
          7 kB
          Tao Jie
        5. HDFS-13418.001.patch
          2 kB
          Tao Jie

          Issue Links

            Activity

              People

              • Assignee:
                Tao Jie Tao Jie
                Reporter:
                Tao Jie Tao Jie
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: