Description
The follow do .. while(false) loop seems useless to me. The code intended to retry but it never worked. Let's fix it.
ShortCircuitReplicaInfo info = null; do { if (closed) { LOG.trace("{}: can't fethchOrCreate {} because the cache is closed.", this, key); return null; } Waitable<ShortCircuitReplicaInfo> waitable = replicaInfoMap.get(key); if (waitable != null) { try { info = fetch(key, waitable); } catch (RetriableException e) { LOG.debug("{}: retrying {}", this, e.getMessage()); } } } while (false);