[HDFS-13330] ShortCircuitCache#fetchOrCreate never retries

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.2.0, 3.1.1, 3.0.3
• Assignee: Gabor Bota
• Reporter: Wei-Chiu Chuang
• Created: 22/Mar/18 20:50
• Updated: 02/Oct/19 17:14
• Resolved: 14/Apr/18 00:02

Description

The follow do .. while(false) loop seems useless to me. The code intended to retry but it never worked. Let's fix it.

ShortCircuitReplicaInfo info = null;
do {
  if (closed) {
    LOG.trace("{}: can't fethchOrCreate {} because the cache is closed.",
        this, key);
    return null;
  }
  Waitable<ShortCircuitReplicaInfo> waitable = replicaInfoMap.get(key);
  if (waitable != null) {
    try {
      info = fetch(key, waitable);
    } catch (RetriableException e) {
      LOG.debug("{}: retrying {}", this, e.getMessage());
    }
  }
} while (false);